Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group should not create multiple traces #381

Closed
cpsievert opened this issue Jan 5, 2016 · 4 comments
Closed

group should not create multiple traces #381

cpsievert opened this issue Jan 5, 2016 · 4 comments

Comments

@cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Jan 5, 2016

The group argument in plot_ly() should probably be translated the same way as ggplot2's group aesthetic.

Among other things, this would make it easier to create candlestick charts requested in #351

@pstoyanov
Copy link

@pstoyanov pstoyanov commented Jan 6, 2016

I don't know if you are referring to the same issue but it seems that color and symbol create a new trace too, which is very different from ggplot. ggplotly lumps color and symbol together to form a new aesthetic. I asked a question on SO about it: http://stackoverflow.com/questions/34582584/how-to-simultaneously-apply-color-shape-size-in-a-scatter-plot

Don't know if this is intentional, I am still very new to plotly.

@alyst
Copy link
Contributor

@alyst alyst commented Jan 11, 2016

+1: looks like group overrides color argument

@alyst
Copy link
Contributor

@alyst alyst commented Jan 13, 2016

@cpsievert I would like to fix this, but at the moment I don't have a good understanding of R plotly and plotly.js internals. It looks like the colors are not assigned in traceify(); does it at all happen in R or in plotply.js? Could you please give me some clues where to look? TIA!

@cpsievert
Copy link
Contributor Author

@cpsievert cpsievert commented Jul 14, 2016

Closed via d2bf2a1.

@cpsievert cpsievert closed this Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants