Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and simplify installation instructions #222

Merged
merged 1 commit into from Jul 5, 2020

Conversation

ethanwhite
Copy link
Member

Installation is now easier and more stable due to improvements in reticulate.
These changes update the minimum reticulate requirements and simplify
the installation instructions accordingly.

Closes #214.

Copy link
Collaborator

@ha0ye ha0ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Is there a specific reason to install rdataretriever before installing retriever? I think the steps in Basic Installation might flow better if you swap lines 46 and 47, so that the reticulate installation and commands are grouped together, and then the rdataretriever installation and commands.

…er and more stable due to improvements in reticulate.These changes update the minimum reticulate requirements and simplifythe installation instructions accordingly.* This removes the need for windows specific install instructions,closes ropensci#196, and closes ropensci#199.* The updates to reticulate also fix ropensci#176.Closes ropensci#214.
@ethanwhite
Copy link
Member Author

Thanks @ha0ye! Good catch on the order. I was originally using rdataretriever::install_retriever() there, hence the order, but this ended up being more robust and I think makes what's going on clearer. I've updated the order as suggested.

@henrykironde henrykironde merged commit 8b9ca9f into ropensci:master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants