Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused figure and subfolder from vignette dir #31

Merged
merged 2 commits into from Jul 1, 2015

Conversation

@sebpardo
Copy link
Member

sebpardo commented Jul 1, 2015

The file unnamed-chunk-2.png is a (literally) random knitr figure and wasn't being used. Better to remove and fix devtools::check() NOTE?

unnamed-chunk-2

@sckott

This comment has been minimized.

Copy link
Member

sckott commented Jul 1, 2015

sounds good.

you should also add vignettes/figure to .Rbuildignore so that that dir can be used if images needed in the vignettes

sebpardo added a commit that referenced this pull request Jul 1, 2015
Remove unused figure and subfolder from vignette dir & add vignettes/figure/ to .Rbuildignore
@sebpardo sebpardo merged commit ea1e99b into ropensci:master Jul 1, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.