-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bib2df #124
Comments
Editor checks:
Editor commentsThanks for your submission @ottlngr ! Currently seeking reviewers. It's a good fit and not overlapping.
It is good practice to
✖ write unit tests for all functions, and all package code in general. 91% of
code lines are covered by test cases.
R/bib2df_gather.R:20:NA
R/bib2df_tidy.R:23:NA
R/bib2df_tidy.R:30:NA
R/df2bib.R:20:NA
R/df2bib.R:21:NA
... and 3 more lines
✖ omit "Date" in DESCRIPTION. It is not required and it gets invalid quite
often. A build date will be added to the package when you perform `R CMD build` on it.
✖ avoid long code lines, it is bad for readability. Also, many people prefer
editor windows that are about 80 characters wide. Try make your lines shorter than 80
characters
inst/legacy/bib2df_explore.R:2:1
inst/legacy/bib2df_explore.R:3:1
inst/legacy/bib2df_scrape_l.R:34:1
inst/legacy/bib2df_scrape_l.R:39:1
R/bib2df_gather.R:23:1
... and 8 more lines
✖ avoid sapply(), it is not type safe. It might return a vector, or a list,
depending on the input data. Consider using vapply() instead.
inst/legacy/bib2df_gather2_l.R:2:12
inst/legacy/bib2df_scrape_l.R:6:9
inst/legacy/bib2df_scrape_l.R:37:40
✖ not import packages as a whole, as this can cause name clashes between the
imported packages. Instead, import only the specific functions you need.
✖ avoid 'T' and 'F', as they are just variables which are set to the logicals
'TRUE' and 'FALSE' by default, but are not reserved words and hence can be overwritten
by the user. Hence, one should always use 'TRUE' and 'FALSE' for the logicals.
R/bib2df_gather.R:NA:NA
R/bib2df_tidy.R:NA:NA
R/bib2df_tidy.R:NA:NA Reviewers: @vasantm @adamhsparks |
Updated the package regarding to the
|
thanks @ottlngr , one reviewer found, one more to go |
I've completed my review of bib2df, here are my comments and suggestions. Package ReviewPlease check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
DocumentationThe package includes all the following forms of documentation:
Functionality
Final approval (post-review)
Estimated hours spent reviewing: Total time to review was about 3.5 hours. Review Commentsbib2df offers functionality for working with LaTeX .bib files in R as a General Comments
I'm not sure that this is necessary to include for the end users, but since you have documented these internal functions you can link to the help file for them. I would suggest not including this information here.
Functions
Documentation
Vignette
NEWS.md
Packages Used
Tests
|
thanks for your review @adamhsparks ! |
Thanks for your extensive and detailed feedback, @adamhsparks. I will bundle your remarks in issues soon and process them as soon as possible. |
Don't want to be meticulous, but @vasantm's review is one week overdue now. |
@vasantm please get your review in asap - if you can't do it let me know asap |
Sorry about he dropping th ball on this.
Will revert within the next 3 days
About me: http://vasantmarur.net
On Jul 11, 2017 3:28 AM, "Scott Chamberlain" <notifications@github.com> wrote:
@vasantm <https://github.com/vasantm> please get your review in asap - if
you can't do it let me know asap
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#124 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQztb2_1ikbncrkSlZLF9cAHHIS8h17ks5sMp6AgaJpZM4NxxTN>
.
|
thanks @vasantm |
@vasantm Do you think you can get your review in soon? |
@vasantm Please get your review in soon. If you cannot, please let me know and I will find someone else |
@ottlngr Sorry about the wait - I'll go ahead and do the 2nd review - hopefully I can get it done tomorrow. |
Thanks, @sckott. |
Package ReviewPlease check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
DocumentationThe package includes all the following forms of documentation:
Functionality
some bits from guidelines: Final approval (post-review)
Estimated hours spent reviewing: 2 Review CommentsNice package!
df2bib
df2bib(bib, 5)
#> Error in cat(paste0("@", capitalize(x$Category), "{", x$Bibtexkey, ",\n", :
#> invalid connection bib2df
your function drops the invalid entry (last one) silently > bib2df("stuff2.bib")
# A tibble: 2 x 30
CATEGORY BIBTEXKEY ADDRESS ANNOTE AUTHOR BOOKTITLE CHAPTER
<chr> <chr> <chr> <chr> <list> <chr> <chr>
1 ARTICLE Binmore2008 <NA> <NA> <chr [1]> <NA> <NA>
2 BOOK Osborne1994 New York <NA> <chr [2]> The Economics of Missing Markets, Information and Games 3
# ... with 23 more variables: CROSSREF <chr>, EDITION <chr>, EDITOR <list>, HOWPUBLISHED <chr>, INSTITUTION <chr>,
# JOURNAL <chr>, KEY <chr>, MONTH <chr>, NOTE <chr>, NUMBER <chr>, ORGANIZATION <chr>, PAGES <chr>, PUBLISHER <chr>,
# SCHOOL <chr>, SERIES <chr>, TITLE <chr>, TYPE <chr>, VOLUME <chr>, YEAR <dbl>, TITLE.1 <chr>, AUTHOR.1 <chr>,
# PUBLISHER.1 <chr>, YEAR.1 <chr> while bibtex::read.bib("stuff2.bib")
#> Error: Invalid bib file
|
@ottlngr both reviews in now let me know if you have any questions about my review or the process in general |
Thanks for your review and useful comments, @sckott.
I would not say it is beyond scope. But when creating Will have to think about that a bit more, but there will be some kind of solutions for this as well as for the rejecting of whole entries. |
Sounds good @ottlngr - i can see the argument against verifying bib files - just nudging a bit in direction of helping users a bit more |
I think this makes sense for the And the first case I described, reading multiple
Do you think of more examples in the documentation or in the vignette? Or both? How does the final review process work? Do I have to provide some code that demonstrates my changes? |
true, it is easy to do. do show how to do it
i think just in docs
There isn't one way to do this. When i submit my own packages for review, I find it easiest to open an issue in the repo for each issue raised by a reviewer - and I label with |
Sorry for the delay! Here is what I achieved based on your reviews:
I tried to document each step in a single commit with a somewhat meaningful commit message: https://github.com/ottlngr/bib2df/commits/master If you have any questions or want some kind of demonstration of specific (new) features just let me know. Thanks to @adamhsparks and @sckott again your helpful and detailed reviews! |
Thanks @ottlngr, this all sounds great. I'll have a look at what you've done this weekend. |
Thanks very much @ottlngr - will have a look soon and get back to you |
Thanks for your efforts to address my comments, @ottlngr. There are some issues to be addressed first before I can check off on accepting this package. Comments in code
The vignette
|
Thanks, @adamhsparks for the feedback, especially for the hint to use
I agreed to all your comments, see the commits below for details: ropensci/bib2df@d21428e |
Thanks @ottlngr. Line 65 of README.Rmd, please correct the spelling of "Community"
Aside from that, looks good to me. I've checked the approval box in my original review. |
Sorry for the typo - just noticed I had not knitted the .Rmd but now all changes are in place: ropensci/bib2df@4ca592b Thanks for the approval, all in all a very helpful and educational process! |
Looks good otherwise. |
I agree with @sckott on this point. You can silently load bib2df elsewhere without echoing the code so that the library loads to execute the examples that follow. |
Thanks for clarification. I had a look at other packages' vignettes - I removed the |
@ottlngr sorry, i meant |
I'm totally confused now about that simple task 😂 I had a look at other vignettes (like https://github.com/ropensci/tabulizer/blob/master/vignettes/tabulizer.Rmd), many do not put And the |
Yes, that's right, |
Approved! thank for your submission @ottlngr !
|
Thanks for guiding me through the whole process, @adamhsparks and @sckott ! I will transfer the repo to rOpenSci this evening (CEST). As soon as the transfer is completed, I will make the needed changes. I'm definitely interested in writing a post for https://ropensci.org/tech-notes/, and maybe even a long-form post for https://ropensci.org/blog - depends on the existence of a suitable narrative and enough spare time to not delay the publication. |
Thanks, sounds good. Okay, just let us know on the post either way. |
Summary
Provides functionality to parse BibTeX files to data.frame which can be used for analyses and visualizations using common tools like
dplyr
,tidyr
andggplot2
. Changes in the data.frame can be written back to a valid BibTeX file.https://github.com/ottlngr/bib2df
Data extraction, because
bib2df
makes entries of a BibTeX file accessible in the most common data structure, the data.frame.Anyone who wants to gain insights in the characteristics and coherences of bibliographic references.
There are a few packages that can deal with BibTeX in general, like
RefManageR
#119 and others mentioned there. These packages are very close to the actual purpose of BibTeX, providing special classes and can be used as reference managing software.bib2df
is not for managing references, but for extracting the data to a common data structure. To my knowledge, onlybib2df
offers parsing to data.frame.Requirements
Confirm each of the following by checking the box. This package:
Publication options
paper.md
with a high-level description in the package root or ininst/
.Detail
R CMD check
(ordevtools::check()
) succeed? Paste and describe any errors or warnings:Does the package conform to rOpenSci packaging guidelines? Please describe any exceptions:
If this is a resubmission following rejection, please explain the change in circumstances:
If possible, please provide recommendations of reviewers - those with experience with similar packages and/or likely users of your package - and their GitHub user names:
The text was updated successfully, but these errors were encountered: