Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsubmission: dbparser #347
submission: dbparser #347
Comments
|
|
|
Hello @MohammedFCIS, thank for your submission, I'll be your handling editor. Editor checks:
Editor commentsHere is output from The are all minor and can be addressed as I look for reviewers, which I am doing now!
|
|
Hello @noamross , I have fixed all goodpractice notes, except test coverage that increased to 92%, is it necessary to increase the test coverage to 100% before resuming review? Thank you |
|
Thank you @MohammedFCIS. No, 100% test coverage is not required. Thank you @emmamendelsohn and @haozhu233 for agreeing to review! Reviews are due 2019-12-09. |
|
Hi @MohammedFCIS! I'm in the process of acquiring the DrugBank dataset--I just responded to a request for more information about how I will use the data. Hopefully they will approve me soon! In the meantime, I was wondering if you considered using the DrugBank API? Could it potentially provide a smoother path for users to access the data? |
|
Hi @emmamendelsohn , first let me thank you so much for taking time and effort to review our package. Regarding DrugBank API, we considered using it at first of course, but decided to proceed with our dbparser for the following reasons:
I hope that answered your question :). Thank you. |
|
Hello @emmamendelsohn and @haozhu233, a reminder that your reviews are due today. |
|
Hi, all, Here is my review. @MohammedFCIS Good job on this package! I totally enjoyed reviewing it! :) Hao Package ReviewPlease check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
DocumentationThe package includes all the following forms of documentation:
Functionality
Final approval (post-review)
Estimated hours spent reviewing: 4 hr
Review CommentsThe Some notes and observations:
See https://devguide.ropensci.org/building.html#recommended-scaffolding
See https://devguide.ropensci.org/building.html#function-and-argument-naming
Package check passed without warning/notes on my machine. |
|
@MohammedFCIS Nice job and thanks for the opportunity to review. Happy to discuss/answer questions. Package ReviewPlease check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide
DocumentationThe package includes all the following forms of documentation:
Functionality
Final approval (post-review)
Estimated hours spent reviewing: 4
Review Comments
Tests run fine with notes on README
DatabaseThis may be due to inexperience on my part, but I was confused about how to save the database using the driver and server argument. I would have liked to be able to save it to a SQLite or other local database using |
|
Hello @haozhu233 and @emmamendelsohn ;
I agree with you, the following issue has been created for that.
Actually it is in my plan to migrate to
The following issue is created to fix that ropensci/dbparser#74
The following issue is created to fix that ropensci/dbparser#75
It is in the beginning already, nothing before it but zip file check. As if the file we have is a zip file we must unzip before checking for the db file.
Added this issue to fix it ropensci/dbparser#14 |
|
Thank you for your reviews, @haozhu233 and @emmamendelsohn. Thank you for responding quickly @MohammedFCIS and we look forward to the revision when you have addressed all the comments. I concur with @emmamendelsohn's comment about the database - I'm not sure if there is a specific reason that MySQL is used, but I think it would make more sense to just let the user use any back-end database they pass. I think you're already doing this. |
|
Hello @haozhu233 and @emmamendelsohn. Happy new year. Kindly find the required changes here https://github.com/Dainanahan/dbparser/labels/ropensci. |
|
Thank you @MohammedFCIS! @emmamendelsohn and @haozhu233, please let us know if the changes address your comments. |
|
Hi @MohammedFCIS! Nice job with the updates--the package feels much more polished. I think the new function names work well. I like that you shortened the README and made a separate tutorial. I'm submitting a PR with a few suggested changes to the README text. Feel free to use or discard as you wish :) I have just a few comments on this second review. Let me know if you need any clarification. Database capabilities
Tutorial
Dataframes versus tibbles
Parsers
R help
|
|
Hello @emmamendelsohn ,
|
|
|
Thank you @emmamendelsohn for clarifications. |
|
Hello @emmamendelsohn , |
|
Hello @emmamendelsohn , @haozhu233 and @noamross, |
|
Thanks for the reminder, @MohammedFCIS. I reviewed your responses to my comments and everything looks good. I just submitted a PR with some edits to the database vignette. @noamross it would be helpful if you could give the vignette a read-through as well. |
|
I'm trying to get in touch with our second reviewer. If I don't hear from him I will go through on his behalf. |
|
Hi, all, sorry for being a little late on getting back on this. I had been quite busy recently. @MohammedFCIS I was actually amazed by the amount of updates you made since I reviewed it last time. Right now this package looks very polished and I would say the software interface looks very clean right now and very user friendly! Impressive! After reviewing this new version several times, I only have a tiny comment regarding the use of |
|
Thank you so much @haozhu233 for your feedback :). It is only due to your and @emmamendelsohn very useful notes ;). |
|
Thank you @emmamendelsohn and @haozhu233 for your responses. I am doing final editor checks and have a an issue on the database vignette / |
|
Thank you @noamross so much for your valuable note. It inspired me to change a lot actually. Please find the fix in that issue ropensci/dbparser#87. |
|
Thank you, @MohammedFCIS, for the update. The package is approved! Thanks for submitting and @emmamendelsohn and @haozhu233 for your reviews! To-dos:
Should you want to acknowledge your reviewers in your package DESCRIPTION, you can do so by making them We've put together an online book with our best practice and tips, this chapter starts the section that's about guidance for post-review. Please tell us what could be improved, the corresponding repo is here. |
|
Hi @noamross . Thank you for the great news, I transferred the repo and waiting to be admin on it to continue the remaining steps. Thank you |
|
You should be all set. |
|
Thanks a lot @noamross :) |
|
Hi @noamross, the following ToDo list is finished.
Thank you |
|
Great work! |

Submitting Author: Mohammed Ali(@submission:)
Repository: https://github.com/Dainanahan/dbparser
Version submitted: v1.0.4
Editor: @noamross
Reviewer 1: @emmamendelsohn
Reviewer 2: @haozhu233
Archive: TBD
Version accepted: TBD
Scope
Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
The package accesses DrugBank DB, extract and transform data into R tibbles, and provides a set of functions to save them in a given SQL database.
Who is the target audience and what are scientific applications of this package?
Pharmaceutical researches who are interested to use data science and machine learning tools in their Drugs Development research
Are there other R packages that accomplish the same thing? If so, how does yours differ or meet
There is drugbankR that might do a similar task by loading the whole DrugBank database into a single R dataframe and provide some queries to for specific data.
On the other hand, dbparser extract drugbank database in to different 75 scientifically detailed dataframe with clear attributes. These dataframes need no extra functionalities to query them except regular base R functionalities. Also these dataframe can be saved in to a given SQL database.
Also, dbparser comes to greater coverage in terms of functionality, documentation, and robust test coverage and error handling, In comparison to drugbankR.
If you made a pre-submission enquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted.
Technical checks
Confirm each of the following by checking the box. This package:
Publication options
JOSS Options
paper.mdmatching JOSS's requirements with a high-level description in the package root or ininst/.MEE Options
Code of conduct