Skip to content

/ spatsoc

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update website URL #1

Merged
merged 1 commit into from Nov 23, 2018
Merged

Update website URL #1

merged 1 commit into from Nov 23, 2018

Conversation

@Bisaloo
Copy link
Contributor

@Bisaloo Bisaloo commented Nov 22, 2018

The URL for pkgdown must contain the protocol and not just the domain name.
@Bisaloo
Update website URL
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
95456a1 
The URL for pkgdown must contain the protocol and not just the domain name.
@robitalec
Copy link
Member

@robitalec robitalec commented Nov 22, 2018

Thanks @Bisaloo!
@robitalec
Copy link
Member

@robitalec robitalec commented Nov 23, 2018

@Bisaloo to confirm, this is in relation to the standard linked here right?
@robitalec robitalec merged commit 7771d83 into ropensci:master Nov 23, 2018
@Bisaloo
Copy link
Contributor Author

@Bisaloo Bisaloo commented Nov 23, 2018

Yes, that's one issue I could notice (the sitemap not following the standard) but it may also have other effects.
@Bisaloo Bisaloo deleted the Bisaloo:patch-1 branch Nov 23, 2018
@robitalec
Copy link
Member

@robitalec robitalec commented Nov 23, 2018

Good to know, thank you.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority: low status: completed type: typo
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Bisaloo @robitalec
You can’t perform that action at this time.