Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent blocks across years from group_times with threshold days #10

Merged
merged 8 commits into from Mar 26, 2019

Conversation

Projects
None yet
1 participant
@robitalec
Copy link
Member

commented Mar 26, 2019

If the threshold is days (e.g. 10 days), the blocks returned are calculated by year (like timegroup), resulting in inconsistent blocks across years.

This doesn't seem ideal (let us know if you disagree!). Timegroups will continue to be by block and year, but blocks will be consistent across years.

@robitalec robitalec merged commit 3bf98c3 into master Mar 26, 2019

@robitalec robitalec deleted the bug/consistent-blocks branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.