Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomization number of ids per iteration #13

Merged
merged 11 commits into from
Apr 27, 2019
Merged

Conversation

robitalec
Copy link
Member

@robitalec robitalec commented Apr 26, 2019

Bug found in randomizations where the number of individuals across iterations differs. A bit tricky to notice with large number of relocations for individuals but stands out when an individual only has a few relocations. (Thanks for spotting this @qwebber).

@robitalec
Copy link
Member Author

robitalec commented Apr 27, 2019

Added tests to detect different number of relocations by individual+iteration+splitBy with randomization type = 'step' and type = 'daily'. Confirmed this bug is not relevant to type = 'trajectory'.

EDIT: test logic for type daily updated by 7b649b0

@robitalec robitalec merged commit b07499c into master Apr 27, 2019
@robitalec robitalec deleted the bug/random-n-ids branch April 27, 2019 20:16
@robitalec robitalec added status: completed and removed status: confirmed bug is reproducible labels Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant