Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/drop timegroup null #24

Merged
merged 18 commits into from Feb 20, 2020
Merged

Conversation

@robitalec
Copy link
Member

@robitalec robitalec commented Feb 20, 2020

If someone mistakenly provides a large DT to (group_pts, edge_nn or edge_dist) without providing a timegroup, it'll compute a huge distance matrix and likely slow/crash their computer.

To avoid this, remove the default NULL for timegroup arguments and require them to explicitly set it to NULL if they want to group/edge without a timegroup.

@robitalec robitalec merged commit 3690be6 into master Feb 20, 2020
@robitalec robitalec deleted the enhancement/drop-timegroup-null branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.