Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line_bearing bidirectional returns the same result #153

Closed
mem48 opened this issue Dec 1, 2016 · 1 comment
Closed

line_bearing bidirectional returns the same result #153

mem48 opened this issue Dec 1, 2016 · 1 comment

Comments

@mem48
Copy link
Collaborator

@mem48 mem48 commented Dec 1, 2016

line_bearing(l, bidirectional= T) and line_bearing(l, bidirectional = F) return the same result

bearingT =  line_bearing(l, bidirectional= T)
bearingF =  line_bearing(l, bidirectional = F)

bearingT == bearingF
[1] TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE TRUE
@Robinlovelace
Copy link
Member

@Robinlovelace Robinlovelace commented Dec 1, 2016

Thanks for reporting.

Another reproducible example, using the example data:

library(stplanr)
lb1 = line_bearing(flowlines, bidirectional = T)
lb2 = line_bearing(flowlines, bidirectional = F)
identical(lb1, lb2) # TRUE
plot(lb1, lb2)

screenshot from 2016-12-01 11-16-22

My interpretation: The Y axis should not be negative - an easy fix I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.