New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stplanr broken with CRAN dplyr #210

Closed
rsbivand opened this Issue Jun 29, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@rsbivand

rsbivand commented Jun 29, 2017

The dplyr release to CRAN has caused havoc - I guess you'd need to condition on dplyr version.

@Robinlovelace

This comment has been minimized.

Collaborator

Robinlovelace commented Jun 29, 2017

Yes - I believe this is the same as #201 I've switched some of them and to this 'tidyeval' thing and rlang - I think @richardellison is up for giving the other failing ones a go. Many thanks for the heads-up - we knew this was coming, just not this soon!

@rsbivand

This comment has been minimized.

rsbivand commented Jun 29, 2017

It is a weakness of tidyverse that they dictate breaking changes. It would be much less destructive if they permitted slower-moving reverse dependencies to stay on an earlier stable version, as much software does. This is cathedral, not bazaar ... and it is going to harm tidyverse, people will give up on a constantly moving target.

@Robinlovelace

This comment has been minimized.

Collaborator

Robinlovelace commented Jun 29, 2017

If it continues to move. Hadley has said sorry for breaking stuff and I suspect things will settle down now that tidyeval is allowing people to write code that is more concise and explicit (in the potentially unlikely event that they actually understand it!).

Best tidyeval resource I've seen: https://cran.r-project.org/web/packages/dplyr/vignettes/programming.html

But yeah longer time-scales and phased approach would be good, especially in summer now many people are on holiday (from Barcelona)!

@Robinlovelace

This comment has been minimized.

Collaborator

Robinlovelace commented Jul 12, 2017

I think this is fixed now - 2 tests on 0.1.9 so far are passing:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment