Issues with dev version of dplyr

[Robinlovelace]

This is an automated email to let you know that:

• A new version of dplyr is ready to go to CRAN. dplyr is
  currently at version 0.8.99.9002 and will become 1.0.0 upon release.

• stplanr uses dplyr and has problems with the new version.

• We plan to submit dplyr to CRAN on May 1.

This is a major release. See
https://www.tidyverse.org/blog/2020/03/dplyr-1-0-0-is-coming-soon/ for
a detailed article about what's changed.

I need your help to keep stplanr and dplyr working together smoothly.
In the next weeks, can you please:

1. Read about the changes to dplyr at
   https://github.com/tidyverse/dplyr/blob/master/NEWS.md.
   This page includes a list of breaking changes, the reasoning behind
   them, and to how to update your code.

2. Carefully inspect the failing checks listed at the bottom of this email.

3. For each failing check, either update your package, or tell me
   that I have a bug. If you have made changes to your package, please
   submit an update to CRAN before May 1.

If you have discovered a bug in dplyr, please file an issue (ideally
with a small reprex that illustrates the problem) at
https://github.com/tidyverse/dplyr/issues. If you're not sure whether
or not you've found a bug, please file an issue at
https://github.com/tidyverse/dplyr/issues for discussion. Breaking
changes that are not listed qualify as bugs.

Please respond to this message if you have any questions.

Thanks,

Romain Francois

== CHECK RESULTS ========================================

• checking examples ...

    ...
                                    TRUE                                 TRUE
            Motorcycle..scooter.or.moped                 Driving.a.car.or.van
                                    TRUE                                 TRUE
               Passenger.in.a.car.or.van                              Bicycle
                                    TRUE                                 TRUE
                                 On.foot       Other.method.of.travel.to.work
                                    TRUE                                 TRUE
    > # Demonstrate the results from oneway and onewaygeo are identical
    > flow_oneway_geo <- onewaygeo(flowlines, attrib = attrib)
    > flow_oneway_sf <- od_oneway(flowlines_sf)
    Joining, by = c("Area.of.residence", "Area.of.workplace")
    Error: `nm` must be `NULL` or a character vector the same length as `x`
    Backtrace:
        █
     1. └─stplanr::od_oneway(flowlines_sf)
     2.   ├─sf::st_as_sf(dplyr::left_join(x_oneway, x_sf))
     3.   ├─dplyr::left_join(x_oneway, x_sf)
     4.   └─dplyr:::left_join.data.frame(x_oneway, x_sf)
     5.     └─dplyr:::join_mutate(...)
     6.       └─rlang::set_names(y[vars$y$key], names(vars$y$key))
    Execution halted

Thanks for the heads-up @romainfrancois

[Robinlovelace]

Nuclear option: deprecate od_oneway() in favour of the od package. Thoughts?

[Robinlovelace]

That specific issue mentioned above seems fixed. But there are other issues that only appear on the dev version of dplyr:

E  creating vignettes (26.1s)
   --- re-building ‘stplanr-od.Rmd’ using rmarkdown
   
   Attaching package: 'dplyr'
   
   The following objects are masked from 'package:stats':
   
       filter, lag
   
   The following objects are masked from 'package:base':
   
       intersect, setdiff, setequal, union
   
   --- finished re-building ‘stplanr-od.Rmd’
   
   --- re-building ‘stplanr-paper.Rmd’ using rmarkdown
   --- finished re-building ‘stplanr-paper.Rmd’
   
   --- re-building ‘stplanr-route-nets.Rmd’ using rmarkdown
   Linking to GEOS 3.8.0, GDAL 3.0.4, PROJ 7.0.0
   2020-04-05 23:27:31 constructing segments
   2020-04-05 23:27:31 building geometry
   2020-04-05 23:27:31 simplifying geometry
   2020-04-05 23:27:31 aggregating flows
   2020-04-05 23:27:31 rejoining segments into linestrings
   Quitting from lines 89-96 (stplanr-route-nets.Rmd) 
   Error: processing vignette 'stplanr-route-nets.Rmd' failed with diagnostics:
   `new` must be a tibble
   --- failed re-building ‘stplanr-route-nets.Rmd’
   
   --- re-building ‘stplanr-routing.Rmd’ using rmarkdown
   --- finished re-building ‘stplanr-routing.Rmd’
   
   --- re-building ‘stplanr.Rmd’ using rmarkdown
   --- finished re-building ‘stplanr.Rmd’
   
   SUMMARY: processing the following file failed:
     ‘stplanr-route-nets.Rmd’
   
   Error: Vignette re-building failed.
   Execution halted

Error: System command 'R' failed, exit status: 1, stdout + stderr:
E> * checking for file ‘/mnt/57982e2a-2874-4246-a6fe-115c199bc6bd/atfutures/repos/stplanr/DESCRIPTION’ ... OK
E> * preparing ‘stplanr’:
E> * checking DESCRIPTION meta-information ... OK
E> * cleaning src
E> * installing the package to build vignettes
E> * creating vignettes ... ERROR
E> --- re-building ‘stplanr-od.Rmd’ using rmarkdown
E> 
E> Attaching package: 'dplyr'
E> 
E> The following objects are masked from 'package:stats':
E> 
E>     filter, lag
E> 
E> The following objects are masked from 'package:base':
E> 
E>     intersect, setdiff, setequal, union
E> 
E> --- finished re-building ‘stplanr-od.Rmd’
E> 
E> --- re-building ‘stplanr-paper.Rmd’ using rmarkdown
E> --- finished re-building ‘stplanr-paper.Rmd’
E> 
E> --- re-building ‘stplanr-route-nets.Rmd’ using rmarkdown
E> Linking to GEOS 3.8.0, GDAL 3.0.4, PROJ 7.0.0
E> 2020-04-05 23:27:31 constructing segments
E> 2020-04-05 23:27:31 building geometry
E> 2020-04-05 23:27:31 simplifying geometry
E> 2020-04-05 23:27:31 aggregating flows
E> 2020-04-05 23:27:31 rejoining segments into linestrings
E> Quitting from lines 89-96 (stplanr-route-nets.Rmd) 
E> Error: processing vignette 'stplanr-route-nets.Rmd' failed with diagnostics:
E> `new` must be a tibble
E> --- failed re-building ‘stplanr-route-nets.Rmd’
E> 
E> --- re-building ‘stplanr-routing.Rmd’ using rmarkdown
E> --- finished re-building ‘stplanr-routing.Rmd’
E> 
E> --- re-building ‘stplanr.Rmd’ using rmarkdown
E> --- finished re-building ‘stplanr.Rmd’
E> 
E> SUMMARY: processing the following file failed:
E>   ‘stplanr-route-nets.Rmd’
E> 
E> Error: Vignette re-building failed.
E> Execution halted

 Stack trace:

 1. devtools::check(args = c("--as-cran"), check_dir = dirname(getwd()))
 2. withr::with_envvar(pkgbuild::compiler_flags(FALSE), action = "prefix",  ...
 3. base:::force(code)
 4. pkgbuild::build(pkg$path, tempdir(), args = build_args, quiet = quiet,  ...
 5. withr::with_temp_libpaths(rcmd_build_tools(options$cmd, c(options$path,  ...
 6. base:::force(code)
 7. pkgbuild:::rcmd_build_tools(options$cmd, c(options$path, options$args),  ...
 8. pkgbuild:::with_build_tools(callr::rcmd_safe(..., env = env,  ...
 9. callr::rcmd_safe(..., env = env, spinner = FALSE, show = FALSE,  ...
 10. callr:::run_r(options)
 11. base:::with(options, with_envvar(env, do.call(processx::run,  ...
 12. base:::with.default(options, with_envvar(env, do.call(processx::run,  ...
 13. base:::eval(substitute(expr), data, enclos = parent.frame())
 14. base:::eval(substitute(expr), data, enclos = parent.frame())
 15. callr:::with_envvar(env, do.call(processx::run, c(list(bin, args = real_cmd ...
 16. base:::force(code)
 17. base:::do.call(processx::run, c(list(bin, args = real_cmdargs,  ...
 18. (function (command = NULL, args = character(), error_on_status = TRUE,  ...
 19. throw(new_process_error(res, call = sys.call(), echo = echo,  ...

 x System command 'R' failed, exit status: 1, stdout + stderr:
E> * checking for file ‘/mnt/57982e2a-2874-4246-a6fe-115c199bc6bd/atfutures/repos/stplanr/DESCRIPTION’ ... OK
E> * preparing ‘stplanr’:
E> * checking DESCRIPTION meta-information ... OK
E> * cleaning src
E> * installing the package to build vignettes
E> * creating vignettes ... ERROR
E> --- re-building ‘stplanr-od.Rmd’ using rmarkdown
E> 
E> Attaching package: 'dplyr'
E> 
E> The following objects are masked from 'package:stats':
E> 
E>     filter, lag
E> 
E> The following objects are masked from 'package:base':
E> 
E>     intersect, setdiff, setequal, union
E> 
E> --- finished re-building ‘stplanr-od.Rmd’
E> 
E> --- re-building ‘stplanr-paper.Rmd’ using rmarkdown
E> --- finished re-building ‘stplanr-paper.Rmd’
E> 
E> --- re-building ‘stplanr-route-nets.Rmd’ using rmarkdown
E> Linking to GEOS 3.8.0, GDAL 3.0.4, PROJ 7.0.0
E> 2020-04-05 23:27:31 constructing segments
E> 2020-04-05 23:27:31 building geometry
E> 2020-04-05 23:27:31 simplifying geometry
E> 2020-04-05 23:27:31 aggregating flows
E> 2020-04-05 23:27:31 rejoining segments into linestrings
E> Quitting from lines 89-96 (stplanr-route-nets.Rmd) 
E> Error: processing vignette 'stplanr-route-nets.Rmd' failed with diagnostics:
E> `new` must be a tibble
E> --- failed re-building ‘stplanr-route-nets.Rmd’
E> 
E> --- re-building ‘stplanr-routing.Rmd’ using rmarkdown
E> --- finished re-building ‘stplanr-routing.Rmd’
E> 
E> --- re-building ‘stplanr.Rmd’ using rmarkdown
E> --- finished re-building ‘stplanr.Rmd’
E> 
E> SUMMARY: processing the following file failed:
E>   ‘stplanr-route-nets.Rmd’
E> 
E> Error: Vignette re-building failed.
E> Execution halted 

Execution halted

Exited with status 1.