Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSfr dep #164
Merged
Sfr dep #164
Conversation
This comment has been minimized.
This comment has been minimized.
|
You won't need any postgresql/postgis stuff since you're not testing sf, but only installing it. |
This comment has been minimized.
This comment has been minimized.
|
TRUE that - just copy pasting. Will remove. |
|
Finally it passes! Good news @richardellison - if you've any new funcionality that could benefit from sf, or code that sf may make faster, here's the place! |
Closed
richardellison
merged commit 42760c9
into
ropensci:sfr
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR adds sf as an import. It's not designed to be merged but should be useful for testing.
The
line_sample()function, for example, uses new functionality in sf thanks to @edzer.Please add any more functions that rely on sf to this branch with a plan to merge in a month or so.
Any ideas how to handle the transition to using sf welcome.
Current thinking: gradual transition rather than revolution.