Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RCurl, data.table and maptools dependencies #169

Merged
merged 4 commits into from Dec 21, 2016

Conversation

@richardellison
Copy link
Collaborator

@richardellison richardellison commented Dec 17, 2016

This PR removes the RCurl and data.table dependencies by replacing RCurl with httr, data.table calls with dplyr::bind_rows and maptools::spRbind with raster::bind.

@richardellison richardellison mentioned this pull request Dec 17, 2016
0 of 4 tasks complete
@richardellison richardellison changed the title Remove RCurl and data.table dependencies Remove RCurl, data.table and maptools dependencies Dec 17, 2016
@richardellison
Copy link
Collaborator Author

@richardellison richardellison commented Dec 17, 2016

This latest commit is failing because of the reference to maptools in line_midpoint(). @Robinlovelace Should I reinstate the maptools dependency or is there an alternative?

@Robinlovelace
Copy link
Member

@Robinlovelace Robinlovelace commented Dec 20, 2016

Ah good point. No quick replacement so please re-instate. Looking at the imports for maptools it seems that there's nothing not already in there other than foreign perhaps: https://cran.r-project.org/web/packages/maptools/index.html

RCurl also removes the bitops dep. In longer run we can look at removing that maptools dep but not a priority before next release.

@richardellison
Copy link
Collaborator Author

@richardellison richardellison commented Dec 20, 2016

maptools also imports lattice. The latest commits adds maptools back in.

@Robinlovelace Robinlovelace merged commit a159b65 into ropensci:master Dec 21, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.