Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSmall change to sum_network_routes function #177
Merged
Conversation
…nations of routes.
|
Looks good. Just looking over these functions and noticed they don't have examples. Could be useful to add I think. |
|
Yes, that's true. The example is in the main SpatialLinesNetwork class rather than the individual functions. I'll add some simple examples. |
|
Thanks |
|
I have added examples. They are derivatives of the main example for the class to keep things consistent. |
|
Good plan to use existing data for examples - will greatly improve the ability of others to use those functions. I've updated the NEWS accordingly: 8b045f3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR speeds up calculating combinations of routes using a SpatialLinesNetwork. This is useful if you want to calculate all routes from a single origin to many destinations or many origins to the same set of destinations.