Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change to sum_network_routes function #177

Merged
merged 2 commits into from
Dec 30, 2016

Conversation

richardellison
Copy link
Collaborator

This PR speeds up calculating combinations of routes using a SpatialLinesNetwork. This is useful if you want to calculate all routes from a single origin to many destinations or many origins to the same set of destinations.

Copy link
Member

@Robinlovelace Robinlovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just looking over these functions and noticed they don't have examples. Could be useful to add I think.

@richardellison
Copy link
Collaborator Author

Yes, that's true. The example is in the main SpatialLinesNetwork class rather than the individual functions. I'll add some simple examples.

@Robinlovelace
Copy link
Member

Thanks

@richardellison
Copy link
Collaborator Author

I have added examples. They are derivatives of the main example for the class to keep things consistent.

@Robinlovelace
Copy link
Member

Good plan to use existing data for examples - will greatly improve the ability of others to use those functions. I've updated the NEWS accordingly: 8b045f3

@Robinlovelace Robinlovelace merged commit 622efdf into ropensci:master Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants