New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install instructions and cran #31

Closed
sckott opened this Issue Sep 28, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@sckott
Copy link
Member

sckott commented Sep 28, 2018

@willpearse can you update the readme? it has install instructions for the wrong github user name https://github.com/ropensci/suppdata#how-to-install-and-load-this-development-version

also, do you plan to submit to CRAN soon? It'd be helpful for me so that I can remove the functionality from fulltext

@willpearse

This comment has been minimized.

Copy link
Collaborator

willpearse commented Sep 30, 2018

I will try and submit to CRAN at the end of this week. I held off because I couldn't get it to reliably pass tests on CRAN's checking server (it checks so many times so quickly that I think it was getting 408 errors or the like. I can just drop them from the CRAN tests and we should be fine.

@willpearse

This comment has been minimized.

Copy link
Collaborator

willpearse commented Sep 30, 2018

...I've fixed this now, but I will leave this issue until I submit

@sckott

This comment has been minimized.

Copy link
Member Author

sckott commented Oct 1, 2018

thanks.

@nuest

This comment has been minimized.

Copy link
Contributor

nuest commented Oct 31, 2018

@willpearse Anything I can do to help?

@willpearse

This comment has been minimized.

Copy link
Collaborator

willpearse commented Nov 1, 2018

@nuest

This comment has been minimized.

Copy link
Contributor

nuest commented Nov 2, 2018

I realise now that I cannot replicate the problem that you probably got after you submitted to CRAN.
Can you forward the email from CRAN if you have one?

Here's what I did in #34

  • seperate tests to one file per publisher and one test_that per feature

This should allow us to have an easier grasp of non-essential tests for each publisher/feature that we can skip.

Tests work locally without issues (R CMD check --as-cran) and also using

rhub::check_with_rdevel(email = "...") # need email because not maintainer
rhub::check_for_cran(email = "...")

Results:

On my machine, I can see a difference in running all test vs. "on CRAN" (~ 170s rep. 110s), as I reduced the number of tests for each service to 1 (sometimes 2).

@sckott

This comment has been minimized.

Copy link
Member Author

sckott commented Dec 18, 2018

Any updates on this? Anything I can do to help get this to CRAN?

@willpearse

This comment has been minimized.

Copy link
Collaborator

willpearse commented Jan 27, 2019

Uploaded to CRAN! Fingers crossed all goes smoothly! Thank you both for your help!!!
🎆

@willpearse willpearse closed this Jan 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment