Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling issues related to upgrade to PDFBox 2.0 #48

Closed
leeper opened this issue Apr 8, 2017 · 8 comments
Closed

Handling issues related to upgrade to PDFBox 2.0 #48

leeper opened this issue Apr 8, 2017 · 8 comments

Comments

@leeper
Copy link
Member

@leeper leeper commented Apr 8, 2017

The tabula-java library is moving to PDFBox 2.0, which will have consequences not only for the tabula API but also for some of the utility functions that tabulizer implements by calling PDFBox classes directly. This is flagged as an issue at tabulizerjars and will likely have numerous consequences for tabulizer. Any help identifying and correcting this issues will be appreciated.

@leeper
Copy link
Member Author

@leeper leeper commented Jul 28, 2017

tabulizerjars has been updated (on a branch) to 1.0.0

@tpaskhalis
Copy link
Collaborator

@tpaskhalis tpaskhalis commented Mar 30, 2018

Thank you for a great package! I did some work on migration to PDFBox 2.0. The changes are here. I have some trouble with setting resolution in make_thumbnail.R through renderImageWithDPI, but otherwise everything seems to work.

@leeper
Copy link
Member Author

@leeper leeper commented Mar 31, 2018

Hey that's great! Is that using the latest tabulizerjars?

@tpaskhalis
Copy link
Collaborator

@tpaskhalis tpaskhalis commented Mar 31, 2018

Yes, it's based on tabula 1.0.1 from the branch of tabulizerjars.

@tpaskhalis
Copy link
Collaborator

@tpaskhalis tpaskhalis commented Apr 4, 2018

I did further work on the migration and feature development. The problem with resolution in thumbnails has been fixed. Added some new functionality, such as extracting text by area and separated out coordinates conversion: pdfbox2.0. My next goal is implementing stream option from #65

@tpaskhalis
Copy link
Collaborator

@tpaskhalis tpaskhalis commented Apr 9, 2018

I think #83 resolves this. So, maybe we could close it and then open separate issues for individual problems if they emerge.

@leeper
Copy link
Member Author

@leeper leeper commented Apr 9, 2018

Great. I'm happy to have you close this then.

@tpaskhalis
Copy link
Collaborator

@tpaskhalis tpaskhalis commented Apr 9, 2018

Ok, great! I'm closing it.

@tpaskhalis tpaskhalis closed this Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.