Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow `filter_taxa` to subset anything that has names, length, and can be subset #178

Closed
zachary-foster opened this issue Jul 22, 2018 · 0 comments
Assignees

Comments

@zachary-foster
Copy link
Collaborator

@zachary-foster zachary-foster commented Jul 22, 2018

I was about to add the ability to work with DNAbin from the ape package, but thought that a more generic solution might be better. Anything could be subset by filter_taxa if it:

  1. Is one-dimension, with a known length (i.e. works with length function)
  2. Can be subset (i.e. [ changes the value of length).
  3. Has per-element names that can be set (i.e. works with names and names<- function)

If I can write a function to test if these are true, then many list-like things could be included without a lot of custom code.

@zachary-foster zachary-foster self-assigned this Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.