Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `branches` function #56

Closed
zachary-foster opened this issue Jun 2, 2017 · 3 comments
Closed

Add `branches` function #56

zachary-foster opened this issue Jun 2, 2017 · 3 comments
Assignees
Milestone

Comments

@zachary-foster
Copy link
Collaborator

@zachary-foster zachary-foster commented Jun 2, 2017

In the group of functions roots, stems, and leaves I think there is a place for everything else, which I was thinking about calling branches.

There is already an is_branch function, so I figure there could be a branches function to make things consistent. It would return info on everything that is not a root, stem, or leaf. The four together would be the whole tree.

@zachary-foster zachary-foster self-assigned this Jun 2, 2017
@sckott
Copy link
Member

@sckott sckott commented Jun 2, 2017

sounds good, can you give an example of what a branch would be?

@zachary-foster
Copy link
Collaborator Author

@zachary-foster zachary-foster commented Jun 2, 2017

A branch is anything that is not a root, stem, or, leaf. Its the interior of the tree after the first split starting from the roots. I am not sure if its really all that useful, but I like completing the metaphor and it should be easy to implement, since I could program it as any taxa not returned by roots(), stems(), or leaves().

@sckott
Copy link
Member

@sckott sckott commented Jun 2, 2017

right, does make sense to complete the set

@zachary-foster zachary-foster added this to the v0.2 milestone Jul 18, 2017
@sckott sckott closed this in e33aace Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.