Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`lookup_tax_data` has a bug that prevents using sequence accession numbers #85

Closed
zachary-foster opened this issue Jul 20, 2017 · 0 comments
Closed
Assignees
Labels
bug
Milestone

Comments

@zachary-foster
Copy link
Collaborator

@zachary-foster zachary-foster commented Jul 20, 2017

There is a test for this that works, so I am not sure of the difference, but the following gives a error

ids <- c("JQ086376.1", "AM946981.2", "JQ182735.1", "CP001396.1", "J02459.1", 
         "AC150248.3", "X64334.1", "CP001509.3", "CP006698.1", "AC198536.1", 
         "JF340119.2", "KF771025.1", "CP007136.1", "CP007133.1", "U39286.1", 
         "CP006584.1", "EU421722.1", "U03462.1", "U03459.1", "AC198467.1", 
         "V00638.1", "CP007394.1", "CP007392.1", "HG941718.1", "HG813083.1", 
         "HG813082.1", "CP007391.1", "HG813084.1", "CP002516.1", "KF561236.1", 
         "JX509734.1", "AP010953.1", "U39285.1", "M15423.1", "X98613.1", 
         "CP006784.1", "CP007393.1", "CU928163.2", "AP009240.1", "CP007025.1", 
         "CP006027.1", "CP003301.1", "CP003289.1", "CP000946.1", "CP002167.1", 
         "HG428755.1", "JQ086370.1", "CP001846.1", "CP001925.1", "X99439.1", 
         "AP010958.1", "CP001368.1", "AE014075.1", "CP002212.1", "CP003034.1", 
         "CP000243.1", "AY940193.1", "CP004009.1", "JQ182732.1", "U02453.1", 
         "AY927771.1", "BA000007.2", "CP003109.1", "CP007390.1", "U02426.1", 
         "U02425.1", "CP006262.1", "HG738867.1", "U00096.3", "FN554766.1", 
         "CP001855.1", "L19898.1", "AE005174.2", "FJ188381.1", "AK157373.1", 
         "JQ182733.1", "U39284.1", "U37692.1", "AF129072.1", "FM180568.1", 
         "CP001969.1", "HE616528.1", "CP002729.1", "JF974339.1", "AB248924.1", 
         "AB248923.1", "CP002291.1", "X98409.1", "CU928161.2", "CP003297.1", 
         "FJ797950.1", "CP000038.1", "U82598.1", "CP002211.1", "JQ806764.1", 
         "U03463.1", "CP001665.1")
contaminants <- lookup_tax_data(ids, type = "seq_id", database = "ncbi")\

Error: Must specify db! 

I looked at the code and indeed taxize::classification did not have a db set. Dont know why it worked before. I have fixed it. @sckott, should we do a bug fix release? Maybe wait a few days and see if any other bugs emerge?

@zachary-foster zachary-foster added the bug label Jul 20, 2017
@zachary-foster zachary-foster added this to the v0.2 milestone Jul 20, 2017
@zachary-foster zachary-foster self-assigned this Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.