Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do with cases with no data/results #95

Closed
sckott opened this issue Aug 10, 2017 · 3 comments · Fixed by #107
Closed

What to do with cases with no data/results #95

sckott opened this issue Aug 10, 2017 · 3 comments · Fixed by #107
Assignees
Milestone

Comments

@sckott
Copy link
Member

@sckott sckott commented Aug 10, 2017

e.g., when using taxize, a user will often have some taxa with matches and some with no matches. We then have to turn the results into taxa pkg classes. Right now taxa classes can't do no data unless pass in e.g,. empty string like "" -

maybe we should explicitly handle this so that "null" classes are supported and are supported when combining classes, etc. (supported could mean for null objects that they are dropped or something, not sure yet)

@zachary-foster

This comment has been minimized.

Copy link
Collaborator

@zachary-foster zachary-foster commented Aug 11, 2017

Yea, something to think about. This is related to #90.

@sckott

This comment has been minimized.

Copy link
Member Author

@sckott sckott commented Aug 11, 2017

thx, yep, def. related

@zachary-foster

This comment has been minimized.

Copy link
Collaborator

@zachary-foster zachary-foster commented Aug 18, 2017

oops, did not mean to close

@sckott sckott self-assigned this Dec 6, 2017
sckott added a commit that referenced this issue Dec 15, 2017
done for taxon, taxon_name, taxon_id, taxon_rank, and taxa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.