Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starts to add null data patterns to methods #107

Merged
merged 3 commits into from Dec 18, 2017
Merged

Starts to add null data patterns to methods #107

merged 3 commits into from Dec 18, 2017

Conversation

@sckott
Copy link
Member

sckott commented Dec 15, 2017

fix #95

let me know what you think @zachary-foster

sckott added 3 commits Dec 15, 2017
done for taxon, taxon_name, taxon_id, taxon_rank, and taxa
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 15, 2017

Codecov Report

Merging #107 into master will decrease coverage by 0.12%.
The diff coverage is 76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   76.38%   76.25%   -0.13%     
==========================================
  Files          21       21              
  Lines        2071     2085      +14     
==========================================
+ Hits         1582     1590       +8     
- Misses        489      495       +6
Impacted Files Coverage Δ
R/taxon_rank.R 100% <100%> (ø) ⬆️
R/taxon_name.R 100% <100%> (ø) ⬆️
R/taxon_id.R 100% <100%> (ø) ⬆️
R/taxon.R 92.3% <100%> (+0.15%) ⬆️
R/hierarchy.R 33.33% <33.33%> (-0.41%) ⬇️
R/taxa.R 92.59% <86.66%> (-7.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3abca2...cc7d0a4. Read the comment docs.

@zachary-foster

This comment has been minimized.

Copy link
Collaborator

zachary-foster commented Dec 18, 2017

LGTM

@zachary-foster zachary-foster merged commit 922d676 into master Dec 18, 2017
2 of 4 checks passed
2 of 4 checks passed
codecov/patch 76% of diff hit (target 76.38%)
Details
codecov/project 76.25% (-0.13%) compared to c3abca2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.