Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_tsn #18

Closed
eduardszoecs opened this issue Aug 31, 2012 · 1 comment
Closed

get_tsn #18

eduardszoecs opened this issue Aug 31, 2012 · 1 comment

Comments

@eduardszoecs
Copy link
Member

Just an idea: shouldn't get_tsn() only return the tsn-numbers?
So no need for a) 'itistermscomname', 'itistermssciname', or 'tsnsvernacular', 'tsnfullhir', 'tsnhirdown',
and b)
the data.frame returned by the ritis functions (only the tsn col is necessary).

I dont know, there are two ways: Change all the ritis functions
or
keep them as they are and wrap their output into get_tsn. (as in my previously closed pull request?)
I think the second way would be less work? What do you think?

@sckott sckott mentioned this issue Sep 1, 2012
@sckott
Copy link
Contributor

sckott commented Sep 1, 2012

Yeah, you're right that the get_tsn fxn should return just the TSN itself. Yeah, if you want, or i could, remove 'itistermscomname', 'itistermssciname', or 'tsnsvernacular', 'tsnfullhir', and 'tsnhirdown'.

@sckott sckott closed this as completed Sep 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants