You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just an idea: shouldn't get_tsn() only return the tsn-numbers?
So no need for a) 'itistermscomname', 'itistermssciname', or 'tsnsvernacular', 'tsnfullhir', 'tsnhirdown',
and b)
the data.frame returned by the ritis functions (only the tsn col is necessary).
I dont know, there are two ways: Change all the ritis functions
or
keep them as they are and wrap their output into get_tsn. (as in my previously closed pull request?)
I think the second way would be less work? What do you think?
The text was updated successfully, but these errors were encountered:
Yeah, you're right that the get_tsn fxn should return just the TSN itself. Yeah, if you want, or i could, remove 'itistermscomname', 'itistermssciname', or 'tsnsvernacular', 'tsnfullhir', and 'tsnhirdown'.
Just an idea: shouldn't get_tsn() only return the tsn-numbers?
So no need for a) 'itistermscomname', 'itistermssciname', or 'tsnsvernacular', 'tsnfullhir', 'tsnhirdown',
and b)
the data.frame returned by the ritis functions (only the tsn col is necessary).
I dont know, there are two ways: Change all the ritis functions
or
keep them as they are and wrap their output into get_tsn. (as in my previously closed pull request?)
I think the second way would be less work? What do you think?
The text was updated successfully, but these errors were encountered: