Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Affixing colours for R classes in `vis_dat` #26
I'm not sure if there's an established palette for this sort of thing, but I guess I could look into using a nice text editor scheme for a starting point.
Thoughts are very welcome!
Grey = missing
That is my most fervently held belief.
Otherwise, I wonder if there is either something you should copy (Trifacta?) or some principles you should obey, relating to common forms of colourblindness, prevalence of different variables types, or what people are trying to distinguish. Re: the last thing, that actually means you would want character and factor to be really different because having a factor that you think is character is a huge source of data analysis headaches.
Whatever you do, seems like you'd want to make it fairly easy for user to change this palllete or look at "this" vs. everything else.
`vis_dat(data, compare = "Factor")`
And then ask people to describe which two (or more) are often mistaken for another?
Perhaps this data-driven approach a bit too meta, though.
I have a hard time telling the difference between the issue and the example above. But basically agree someone might want to look at only one issue at a time, i.e. just missing data or data that meet some other criteria.
I think your own common sense and thought are enough (vs. survey). My point: the initial proposal has red for character and green for factor, which would be tough on colourblind people trying to find unexpected factors. Another important distinction to help people notice is probably integer vs double.
added a commit
May 31, 2016
Thanks @jennybc !
I'm really keen to implement #15 when I get the chance, at this stage here is where I'm at with the colours being fixed. commit b24cecc has added a
Default is just as-is
vis_dat(airquality, palette = "default")
vis_dat(airquality, palette = "qual")
This is nice, but not super colour blind friendly.
"cb_safe" provides a better solution.
vis_dat(airquality, palette = "cb_safe")
One issue from here is that I have only provided colours for the 6 classes ("character", "date", "factor", "integer", "logical", "numeric"), and I would like to maybe provide a different set of colours for any extra classes that fall outside of these. Perhaps I can create a palette builder function that takes the classes in the plot, this might be able to link to
These colours are just working ideas at the moment.
I couldn't find colours from trifacta, at this stage I am using info from colorbrewer2.org