Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow `vis_dat` and `vis_miss` to use variable names with spaces #3

Closed
njtierney opened this Issue Feb 1, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@njtierney
Copy link
Collaborator

njtierney commented Feb 1, 2016

Just a little note here for now. I'll add in some reproducible code soon, but basically I have some new data I read in with readxl::read_excel() that has variables named with spaces in them.

Normally these are handled with backticks - e.g., a bad variable name, but it looks like aes_string() doesn't really like that.

As an important feature of visdat is to visualise data when it is hot off the presses, it should be able to handle poorly named variables.

@njtierney

This comment has been minimized.

Copy link
Collaborator Author

njtierney commented Mar 6, 2016

I'm just journalling my thoughts as I go here so I don't forget.

This is an important issue that I'd like to address before release to CRAN.

Perhaps the next feature to work on would be incorporating expectations, as in #15, and this would be next in line, before I start the process of tidying up all of the package warnings/notes for CRAN release.

@njtierney

This comment has been minimized.

Copy link
Collaborator Author

njtierney commented Apr 22, 2016

vis_dat now accepts variables with spaces in their names 3db5175

@njtierney njtierney closed this Apr 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.