New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for vis_expect #73

Closed
njtierney opened this Issue Mar 29, 2018 · 2 comments

Comments

1 participant
@njtierney
Collaborator

njtierney commented Mar 29, 2018

Need to add:

  • % of cases that the expectation is TRUE (a la vis_miss)
    - [ ] Maybe add in the % of cases true in each column?
  • Tests for expect_frame
  • Flesh out documentation for expect_frame
  • Add expect_frame into vignette (Along with vis_cor()

@njtierney njtierney added this to To do in CRAN 5.0 release Apr 5, 2018

@njtierney njtierney added the V0.5.0 label Jun 4, 2018

@njtierney njtierney moved this from To do to Doing in CRAN 5.0 release Jun 4, 2018

@njtierney

This comment has been minimized.

Show comment
Hide comment
@njtierney

njtierney Jun 4, 2018

Collaborator

Here is the current behaviour (as of commit be1fdf6)

library(visdat)
dat_test <- tibble::tribble(
            ~x, ~y,
            -1,  "A",
            0,  "B",
            1,  "C"
            )

vis_expect(dat_test,
           ~ .x == -1)

vis_expect(airquality,
           ~ .x == 5.1)

Created on 2018-06-04 by the reprex package (v0.2.0).

Collaborator

njtierney commented Jun 4, 2018

Here is the current behaviour (as of commit be1fdf6)

library(visdat)
dat_test <- tibble::tribble(
            ~x, ~y,
            -1,  "A",
            0,  "B",
            1,  "C"
            )

vis_expect(dat_test,
           ~ .x == -1)

vis_expect(airquality,
           ~ .x == 5.1)

Created on 2018-06-04 by the reprex package (v0.2.0).

@njtierney

This comment has been minimized.

Show comment
Hide comment
@njtierney

njtierney Jun 4, 2018

Collaborator

At the moment I am deciding to leave out the percentages of expectations that are TRUE in each column, I think you would be better off getting this kind of information from a dataframe summary method - as discussed in #83

I am going to keep the NA values as grey for the moment, but these might need to change in the future.

Collaborator

njtierney commented Jun 4, 2018

At the moment I am deciding to leave out the percentages of expectations that are TRUE in each column, I think you would be better off getting this kind of information from a dataframe summary method - as discussed in #83

I am going to keep the NA values as grey for the moment, but these might need to change in the future.

njtierney added a commit that referenced this issue Jun 4, 2018

@njtierney njtierney referenced this issue Jun 4, 2018

Merged

Expect frame #84

njtierney added a commit that referenced this issue Jun 4, 2018

Merge pull request #84 from ropensci/expect-frame
Expect frame- helps to address some parts of #73

@njtierney njtierney added this to the V0.2.0 milestone Jun 5, 2018

@njtierney njtierney removed the V0.5.0 label Jun 6, 2018

@njtierney njtierney closed this in 634766b Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment