Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior with readr 1.2.0 #103

Merged
merged 1 commit into from Nov 28, 2018

Conversation

@jimhester
Copy link
Contributor

commented Nov 21, 2018

readr 1.2.0 changes the default behavior of the guess_parser, to not
guess integer types by default. To opt-into the current behavior you
need to pass guess_integer = TRUE.

I plan to submit readr soon, so you will need to release visdat with this change to fix a test failure on CRAN.

Sorry for the breakage!

Fix behavior with readr 1.2.0
readr 1.2.0 changes the default behavior of the guess_parser, to not
guess integer types by default. To opt-into the current behavior you
need to pass `guess_integer = TRUE`.

@njtierney njtierney merged commit 1e1632a into ropensci:master Nov 28, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@njtierney

This comment has been minimized.

Copy link
Collaborator

commented Nov 28, 2018

Thanks for this, Jim! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.