Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared tidyverse dependency #76

Open
adamhsparks opened this issue Aug 27, 2019 · 6 comments · Fixed by #77

Comments

@adamhsparks
Copy link
Member

commented Aug 27, 2019

I asked @jeroen why weathercan didn't have it's own spiffy https://docs.ropensci.org/ webpage as I was updating links in the documentation of GSODR for a new CRAN release.

Apparently you have an undeclared dependency, tidyverse see the log here for more: https://dev.ropensci.org/job/weathercan/35/console

@jeroen

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

If you add Suggests: tidyverse to your package description, it should fix the site!

@adamhsparks

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Yes, I thought about a PR, but wasn't sure if it was desirable to keep tidyverse in Suggests seeing some past issues it looked like it was being removed from weathercan perhaps.

@jeroen

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

If tidyverse is used in vignettes, it has to be in Suggests to pass CMD check as well...

@steffilazerte

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

I think the problem is technically in the articles (for pkgdown) not the vignettes. Ideally I'll just change the vignettes to use the specific packages, not tidyverse. I'm away right now but will get to it later. Thanks!

@steffilazerte

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

@jeroen, we're still having a problem with one of the articles not compiling on the jenkins server, due to missing packages. Currently it's a package that I have no idea where it comes from (seems to be a ggplot2 dependency?).

I could just add that package to the suggest, but the problem I have is that there is one quite advanced article (i.e. not a vignette, but an article for the pkgdown website) that requires special packages that weathercan doesn't depend on. The easy solution is to add them to the weathercan suggests field, but I'm reluctant to do that when they're not at all required for weathercan itself.

Is there a way to specify that these packages need to be installed for the compilation of the documentation on the ropensci/jenkins server? i.e. some sort of yaml file I can add? or a way to customized the build itself?

@jeroen

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

OK fair enough. I usually put all stuff in suggests, but I can imagine you don't like that. I opened an issue here: ropensci/docs#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.