Skip to content

/ webmockr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix date slot in httr response object #58

Closed
sckott opened this issue Feb 1, 2019 · 0 comments
Closed

fix date slot in httr response object #58

sckott opened this issue Feb 1, 2019 · 0 comments
Labels
adapter bug
Milestone
v0.3.4

Comments

@sckott
Copy link
Member

@sckott sckott commented Feb 1, 2019

via vcr issue ropensci/vcr#91
@sckott sckott added this to the v0.3.2 milestone Feb 1, 2019
@sckott sckott added adapter bug labels Feb 1, 2019
sckott added a commit that referenced this issue Feb 1, 2019
@sckott
fix #58 fix date slot in httr response object to match what real requ…
9b88fc3 
…ests return

add HttrAdapter tests, were missing
include HttrAdapter tests for the date slot in response object
bump dev version
sckott added a commit that referenced this issue Feb 1, 2019
@sckott
remove old httr response date code #58
9a3d75d
@sckott sckott mentioned this issue Feb 2, 2019
Merged
@sckott sckott closed this in #61 Feb 2, 2019
sckott added a commit that referenced this issue Feb 2, 2019
@sckott
fix #58 fix date slot in httr response object to match what real requ…
17091a1 
…ests return

add HttrAdapter tests, were missing
include HttrAdapter tests for the date slot in response object
bump dev version
sckott added a commit that referenced this issue Feb 2, 2019
@sckott
remove old httr response date code #58
f3b4947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adapter bug
Projects
None yet
Milestone
v0.3.4
Linked pull requests

Successfully merging a pull request may close this issue.

fix httr adapter problems
1 participant
@sckott
You can’t perform that action at this time.