Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing legs planning groups #6

Merged
merged 1 commit into from Jul 29, 2016
Merged

fixing legs planning groups #6

merged 1 commit into from Jul 29, 2016

Conversation

@nlyubova
Copy link
Member

nlyubova commented Jul 21, 2016

No description provided.

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor

mikaelarguedas commented Jul 21, 2016

Renaming looks good to me. Np for moving from a chain definition to a joint listing in each group.

I have trouble to understand the use of foot_virtual. Could you give more context about what it is used for and why ?
AFAIK Virtual joints are supposed to create virtual links to emulate environment information that is not published by the robot by default (e.g. odometry). But in this case foot_virtual_joint it is a fixed joint connected to the left foot plant l_sole that is a real link already attached to a joint and published by the robot. So why is a virtual joint needed in this case ?
Given that it is a fixed joint tied to the left foot, what happens if the right leg moves ? foot_virtual_joint will stay the same, is that correct ? Is that the wanted behavior?

@nlyubova

This comment has been minimized.

Copy link
Member Author

nlyubova commented Jul 22, 2016

Thank you,
foot_virtual was in the tutorial for the whole_body control. If you think that it is not needed then I remove it

@nlyubova nlyubova force-pushed the nlyubova:master branch from 822b776 to a1ebd43 Jul 22, 2016
@nlyubova

This comment has been minimized.

Copy link
Member Author

nlyubova commented Jul 23, 2016

Regarding list of joints, I need it like that to make the whole-body working. I'm working on it at the moment and it should be like that : one group of joints and one group as a chain

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor

mikaelarguedas commented Jul 24, 2016

Great, looks good to me,
+1 for squash and merge

@nlyubova nlyubova force-pushed the nlyubova:master branch from a1ebd43 to bce1072 Jul 29, 2016
@nlyubova nlyubova merged commit dd9e6a1 into ros-aldebaran:master Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.