Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to industrial_ci #20

Merged
merged 3 commits into from Oct 30, 2017

Conversation

Projects
None yet
3 participants
@ipa-mdl
Copy link
Contributor

commented Mar 18, 2017

This adds support for lunar
supersedes #8

@ipa-mdl

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2017

I will squash it later (or you could squash-merge).
Downstream tests will be run as soon as ros-industrial/industrial_ci#137 was merged.

realtime_tools is ready for lunar :D

@ipa-mdl ipa-mdl force-pushed the ipa-mdl:patch-1 branch from 102cdcc to bc40c02 Mar 18, 2017

@davetcoleman
Copy link
Member

left a comment

thanks, only small changes needed

.travis.yml Outdated
@@ -1,47 +1,30 @@
# Travis Continuous Integration Configuration File For ROS Control Projects
# Author: Dave Coleman

This comment has been minimized.

Copy link
@davetcoleman

davetcoleman Mar 22, 2017

Member

since you are switching to industrial_ci, you can remove me as author

.travis.yml Outdated
sudo: required
dist: trusty
language: generic

notifications:
email:
recipients:
- davetcoleman@gmail.com

This comment has been minimized.

Copy link
@davetcoleman

davetcoleman Mar 22, 2017

Member

remove me here too, please

.travis.yml Outdated
matrix:
- ROS_DISTRO=kinetic ROS_REPO=ros
- ROS_DISTRO=kinetic ROS_REPO=ros-shadow-fixed
- ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed UPSTREAM_WORKSPACE=debian

This comment has been minimized.

Copy link
@davetcoleman

davetcoleman Mar 22, 2017

Member

why not add non-shadow-fixed for lunar also?

@ipa-mdl

This comment has been minimized.

Copy link
Contributor Author

commented Oct 28, 2017

@davetcoleman: I have removed you from the notifcations.
@bmagyar: I have added the same notifications as for ros-controls/ros_control.

@bmagyar

This comment has been minimized.

Copy link
Member

commented Oct 29, 2017

Great, thank you!

.travis.yml Outdated
- ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed
matrix:
allow_failures:
- env: ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed

This comment has been minimized.

Copy link
@bmagyar

bmagyar Oct 29, 2017

Member

Do we really want to allow failures? I think it's better not

This comment has been minimized.

Copy link
@ipa-mdl

ipa-mdl Oct 29, 2017

Author Contributor

This was just copied from the other repo, I will adjust it.

.travis.yml Outdated
matrix:
- ROS_DISTRO=kinetic ROS_REPO=ros
- ROS_DISTRO=kinetic ROS_REPO=ros-shadow-fixed
- ROS_DISTRO=lunar ROS_REPO=ros-shadow-fixed

This comment has been minimized.

Copy link
@bmagyar

bmagyar Oct 29, 2017

Member

Could you please also add regular repo for Lunar?

@ipa-mdl

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2017

I have updated the config, please squash-merge.

The raised points have been addressed

@bmagyar bmagyar merged commit ca9c5e9 into ros-controls:kinetic-devel Oct 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bmagyar bmagyar referenced this pull request Oct 30, 2017

Closed

Set up Travis to run tests #8

@ipa-mdl ipa-mdl referenced this pull request Nov 8, 2017

Merged

switched to industrial_ci #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.