Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export dll (runtime binaries) on Windows #33

Merged
merged 5 commits into from Feb 4, 2019

Conversation

Projects
None yet
3 participants
@kejxu
Copy link
Contributor

commented Jan 31, 2019

.so are exported on Linux using LIBRARY property, but .dll needs to use RUNTIME. to fix this, we could remove the LIBRARY specification, and export all the output to package_lib, so library and runtime are all exported

or we could add RUNTIME DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}

@kejxu kejxu referenced this pull request Feb 1, 2019

Merged

export dll on Windows #373

@ipa-mdl
Copy link
Contributor

left a comment

We should discuss this first in ros-controls/ros_control#373

@ipa-mdl

ipa-mdl approved these changes Feb 4, 2019

@ipa-mdl ipa-mdl merged commit d8de68c into ros-controls:melodic-devel Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kejxu kejxu deleted the kejxu:export_dll_on_Windows branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.