Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flexible Joint States message design doc #2

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Feb 10, 2020

Draft for flexible joint states message

@bmagyar
Copy link
Member Author

bmagyar commented Feb 10, 2020

@jordan-palacios @Karsten1987 I've tried to collect my current ideas and a general specification of what I'd like to see out of this. Please scrutinize and suggest changes, this is more of a discussion opener than a strict design doc at the moment :)

@gavanderhoorn
Copy link

Reminded me of ros-controls/ros_controllers#416 (there are probably others).

@bmagyar
Copy link
Member Author

bmagyar commented Feb 10, 2020

Thanks for that ref @gavanderhoorn ! The end of the unholy trinity of pos-vel-eff is drawing nigh!

@gavanderhoorn
Copy link

gavanderhoorn commented Feb 10, 2020

Would it make sense to try and get some insight into how other control frameworks are modelling / encoding this type of data?

Might provide valuable insights.

What about going for the channel approach (ie: give each value-type its own topic)? JointState is right now typically used as a bus. I appreciate the added complexity of having N topics for N value-types, but it might be worth it.

Another alternative: use a semantically meaningless float64 for everything, and overlay semantics by publishing/providing an Info message. This would be somewhat similar to CameraInfo, where (additional) information is provided OoB. This would not be too nice from a system modelling perspective, but would provide lots of flexibility. Channels between controllers would then exchange primitive data-types instead of composites.

@bmagyar
Copy link
Member Author

bmagyar commented Feb 25, 2020

This document is by no means done, please feel free to open further PR-s with more proposals I am however going to merge it for visibility.

@bmagyar bmagyar merged commit d9f2f14 into master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants