Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard around pragmas #397

Merged
merged 1 commit into from Apr 27, 2021
Merged

guard around pragmas #397

merged 1 commit into from Apr 27, 2021

Conversation

Karsten1987
Copy link
Contributor

follow up to #393, the pragmas obviously only work on a clang compiler.
The buildfarm is not really happy when using gcc: https://build.ros2.org/job/Fdev__ros2_control__ubuntu_focal_amd64/60/display/redirect?page=changes

@bmagyar fyi

Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice band aid macros

@bmagyar bmagyar merged commit 291e597 into master Apr 27, 2021
@Karsten1987 Karsten1987 deleted the pragma_on_osx branch April 27, 2021 15:32
destogl added a commit to StoglRobotics-forks/ros2_control that referenced this pull request Aug 11, 2022
…reaking

Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants