From 0b1dd83223050b84c9d2b79da2ae14e16cecff3a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20Fr=C3=B6hlich?=
 <christophfroehlich@users.noreply.github.com>
Date: Tue, 27 Feb 2024 20:08:06 +0100
Subject: [PATCH] [CI] reviewer lottery and fail-fast (backport #1047 #1049)
 (#1054)

---
 .github/reviewer-lottery.yml                  | 33 -------------------
 .github/workflows/humble-binary-build.yml     |  1 +
 .../workflows/humble-semi-binary-build.yml    |  1 +
 .github/workflows/iron-binary-build.yml       |  1 +
 .github/workflows/iron-semi-binary-build.yml  |  1 +
 .github/workflows/reviewer_lottery.yml        | 12 +++----
 .github/workflows/rolling-binary-build.yml    |  1 +
 .../workflows/rolling-semi-binary-build.yml   |  1 +
 8 files changed, 10 insertions(+), 41 deletions(-)
 delete mode 100644 .github/reviewer-lottery.yml

diff --git a/.github/reviewer-lottery.yml b/.github/reviewer-lottery.yml
deleted file mode 100644
index c6580eacd4..0000000000
--- a/.github/reviewer-lottery.yml
+++ /dev/null
@@ -1,33 +0,0 @@
-groups:
-  # Default reviewers for all pull requests.
-  # Usually, at least on of the maintainers should approve PR before merging.
-  # The best is if two maintainers do that.
-  - name: maintainers # name of the group
-    reviewers: 2 # how many reviewers do you want to assign?
-    internal_reviewers: 1 # how many reviewers do you want to assign when the PR author belongs to this group?
-    usernames: # github usernames of the reviewers
-      - bmagyar
-      - destogl
-
-  # Reviewers group to get broader feedback.
-  - name: reviewers
-    reviewers: 5
-    usernames:
-      - aprotyas
-      - arne48
-      - bijoua29
-      - christophfroehlich
-      - DasRoteSkelett
-      - duringhof
-      - erickisos
-      - fmauch
-      - jaron-l
-      - livanov93
-      - mcbed
-      - moriarty
-      - olivier-stasse
-      - peterdavidfagan
-      - progtologist
-      - saikishor
-      - VanshGehlot
-      - VX792
diff --git a/.github/workflows/humble-binary-build.yml b/.github/workflows/humble-binary-build.yml
index 989805733f..df449caecb 100644
--- a/.github/workflows/humble-binary-build.yml
+++ b/.github/workflows/humble-binary-build.yml
@@ -18,6 +18,7 @@ jobs:
   binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with:
diff --git a/.github/workflows/humble-semi-binary-build.yml b/.github/workflows/humble-semi-binary-build.yml
index 1d9d3bd1fb..aaed9c8ca2 100644
--- a/.github/workflows/humble-semi-binary-build.yml
+++ b/.github/workflows/humble-semi-binary-build.yml
@@ -17,6 +17,7 @@ jobs:
   semi_binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with:
diff --git a/.github/workflows/iron-binary-build.yml b/.github/workflows/iron-binary-build.yml
index 079620771c..ec1e93c805 100644
--- a/.github/workflows/iron-binary-build.yml
+++ b/.github/workflows/iron-binary-build.yml
@@ -24,6 +24,7 @@ jobs:
   binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with:
diff --git a/.github/workflows/iron-semi-binary-build.yml b/.github/workflows/iron-semi-binary-build.yml
index 064be40555..a704875a18 100644
--- a/.github/workflows/iron-semi-binary-build.yml
+++ b/.github/workflows/iron-semi-binary-build.yml
@@ -23,6 +23,7 @@ jobs:
   semi_binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with:
diff --git a/.github/workflows/reviewer_lottery.yml b/.github/workflows/reviewer_lottery.yml
index ed28964e01..0584f4a7f3 100644
--- a/.github/workflows/reviewer_lottery.yml
+++ b/.github/workflows/reviewer_lottery.yml
@@ -1,14 +1,10 @@
 name: Reviewer lottery
+# pull_request_target takes the same events as pull_request,
+# but it runs on the base branch instead of the head branch.
 on:
   pull_request_target:
     types: [opened, ready_for_review, reopened]
 
 jobs:
-  test:
-    runs-on: ubuntu-latest
-    if: github.actor != 'dependabot[bot]' && github.actor != 'mergify[bot]'
-    steps:
-    - uses: actions/checkout@v4
-    - uses: uesteibar/reviewer-lottery@v3
-      with:
-        repo-token: ${{ secrets.GITHUB_TOKEN }}
+  assign_reviewers:
+    uses: ros-controls/ros2_control_ci/.github/workflows/reusable-reviewer-lottery.yml@master
diff --git a/.github/workflows/rolling-binary-build.yml b/.github/workflows/rolling-binary-build.yml
index 7b5a3bda65..acd19e25aa 100644
--- a/.github/workflows/rolling-binary-build.yml
+++ b/.github/workflows/rolling-binary-build.yml
@@ -24,6 +24,7 @@ jobs:
   binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with:
diff --git a/.github/workflows/rolling-semi-binary-build.yml b/.github/workflows/rolling-semi-binary-build.yml
index a20c4d4fd3..432e739b74 100644
--- a/.github/workflows/rolling-semi-binary-build.yml
+++ b/.github/workflows/rolling-semi-binary-build.yml
@@ -23,6 +23,7 @@ jobs:
   semi_binary:
     uses: ros-controls/ros2_control_ci/.github/workflows/reusable-industrial-ci-with-cache.yml@master
     strategy:
+      fail-fast: false
       matrix:
         ROS_REPO: [main, testing]
     with: