Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame id in diff_drive_controller (#521) #522

Merged
merged 1 commit into from Feb 14, 2023

Conversation

tverbele
Copy link

Strips first "/" from namespace and only append once.

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The old code seems odd. Now, sure, if there were a specific reason to do that.

I agree, but the code looks strange/complicated in general. Can we write a test – to understand how this is used at all.

@bmagyar
Copy link
Member

bmagyar commented Feb 10, 2023

... or at least document how you can get the current setup to fail

correction
It was documented in #521

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH the erase line could do with a comment to document it a bit but I think that the appending of namespaces is the result of a conflict resolution gone wrong @destogl , those lines are just plain dumb, we should merge this asap

@destogl destogl linked an issue Feb 14, 2023 that may be closed by this pull request
@destogl destogl enabled auto-merge (squash) February 14, 2023 06:32
@destogl destogl self-requested a review February 14, 2023 06:32
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong frame_id in odometry message of diff_drive_controller
3 participants