New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jade Release #201

Closed
rctoris opened this Issue Apr 7, 2015 · 34 comments

Comments

Projects
None yet
@rctoris

rctoris commented Apr 7, 2015

Just a friendly ping for a potential jade release to help some blocking packages for the upcoming beta.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Apr 14, 2015

+1 for this

ghost commented Apr 14, 2015

+1 for this

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Apr 15, 2015

Member

I'll be spending time on the project in the next weeks, and will take a look at what's needed here. Because of the ROS distro transition, I'd like to take the opportunity to review which behavior and API changes would make sense to incorporate. More concretely, I'm thinking at least of #75 (API break), and ros-controls/ros_controllers#48 (behavior change), which is long overdue.

Member

adolfo-rt commented Apr 15, 2015

I'll be spending time on the project in the next weeks, and will take a look at what's needed here. Because of the ROS distro transition, I'd like to take the opportunity to review which behavior and API changes would make sense to incorporate. More concretely, I'm thinking at least of #75 (API break), and ros-controls/ros_controllers#48 (behavior change), which is long overdue.

@davetcoleman

This comment has been minimized.

Show comment
Hide comment
@davetcoleman
Member

davetcoleman commented Apr 15, 2015

@scpeters

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Apr 23, 2015

Member

Its likely that I'll have some cycles next week to look into this.

Member

adolfo-rt commented Apr 23, 2015

Its likely that I'll have some cycles next week to look into this.

@wjwwood

This comment has been minimized.

Show comment
Hide comment
@wjwwood

wjwwood Apr 23, 2015

Member

+1, let me know if I can help.

Member

wjwwood commented Apr 23, 2015

+1, let me know if I can help.

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Apr 28, 2015

Member

If gazebo_ros_control is moved to the ros-controls organization, (ros-simulation/gazebo_ros_pkgs#179), then it would no longer block the release of desktop-full, and of Jade's beta.

Usually, the release of ros_control and friends has lagged a bit from the core packages. For indigo, we did not make it to the beta, but we did make it to the official release date. I'm trying to aim for a similar timeline with Jade.

Member

adolfo-rt commented Apr 28, 2015

If gazebo_ros_control is moved to the ros-controls organization, (ros-simulation/gazebo_ros_pkgs#179), then it would no longer block the release of desktop-full, and of Jade's beta.

Usually, the release of ros_control and friends has lagged a bit from the core packages. For indigo, we did not make it to the beta, but we did make it to the official release date. I'm trying to aim for a similar timeline with Jade.

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt May 26, 2015

Member

Quick update. My progress on this has been preempted until mid-June because of higher priority tasks. Most (if not all) of the development effort involving API changes has been done in #204, but I still have some TODOs before commiting to the release.

Member

adolfo-rt commented May 26, 2015

Quick update. My progress on this has been preempted until mid-June because of higher priority tasks. Most (if not all) of the development effort involving API changes has been done in #204, but I still have some TODOs before commiting to the release.

@DLu

This comment has been minimized.

Show comment
Hide comment
@DLu

DLu Jul 2, 2015

Not to pile on, but +1 for new features of urdf_tutorial.

DLu commented Jul 2, 2015

Not to pile on, but +1 for new features of urdf_tutorial.

@bduffany

This comment has been minimized.

Show comment
Hide comment
@bduffany

bduffany Aug 29, 2015

Any updates on this?

bduffany commented Aug 29, 2015

Any updates on this?

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Sep 4, 2015

Member

Hi,
The deadline I've set to myself is ROScon. I'll be offline for three weeks starting on Tuesday Sept 8.

I'd like to fix #211, and optionally consider moving gazebo_ros_control to the ros-controls organization, since it's currently living in a limbo state. I'm actively working on that package, so I hope to have something solid for ROScon.

Thanks all for your prolonged patience. The jade release brings quite a few changes that have taken time to get right.

Member

adolfo-rt commented Sep 4, 2015

Hi,
The deadline I've set to myself is ROScon. I'll be offline for three weeks starting on Tuesday Sept 8.

I'd like to fix #211, and optionally consider moving gazebo_ros_control to the ros-controls organization, since it's currently living in a limbo state. I'm actively working on that package, so I hope to have something solid for ROScon.

Thanks all for your prolonged patience. The jade release brings quite a few changes that have taken time to get right.

@werner-ne

This comment has been minimized.

Show comment
Hide comment
@werner-ne

werner-ne Sep 28, 2015

Hi Adolfo, Is your personal deadline until end of this week still valid? thx

werner-ne commented Sep 28, 2015

Hi Adolfo, Is your personal deadline until end of this week still valid? thx

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Oct 1, 2015

Member

Hi. I'm waiting for feedback on #211, which I consider a blocker for the Jade release.

Member

adolfo-rt commented Oct 1, 2015

Hi. I'm waiting for feedback on #211, which I consider a blocker for the Jade release.

@TheDash

This comment has been minimized.

Show comment
Hide comment
@TheDash

TheDash Nov 3, 2015

Can we release this into Jade? It is blocking pr2-gbp/pr2_controllers-release#1

TheDash commented Nov 3, 2015

Can we release this into Jade? It is blocking pr2-gbp/pr2_controllers-release#1

@davetcoleman

This comment has been minimized.

Show comment
Hide comment
@davetcoleman

davetcoleman Nov 4, 2015

Member

+1, can we also fix the velocity controller's feed-forward term?
ros-controls/ros_controllers#142

Member

davetcoleman commented Nov 4, 2015

+1, can we also fix the velocity controller's feed-forward term?
ros-controls/ros_controllers#142

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Nov 13, 2015

Member

All blocking PRs for releasing the ros_control repo have been submitted (#218 and #210). After a pair of eyes gives them a +1, I'll merge and proceed with the pre-release → release sequence.

The idea is to get ros_control and ros_controllers released first. Then I'll see when I find another slot for gazebo_ros_control, which needs to be migrated to Gazebo 5. I don't know if there's a high overhead for this task or not. Hopefully not.

+1, can we also fix the velocity controller's feed-forward term?
ros-controls/ros_controllers#142

I commented directly in #142. It could make it as well.

Member

adolfo-rt commented Nov 13, 2015

All blocking PRs for releasing the ros_control repo have been submitted (#218 and #210). After a pair of eyes gives them a +1, I'll merge and proceed with the pre-release → release sequence.

The idea is to get ros_control and ros_controllers released first. Then I'll see when I find another slot for gazebo_ros_control, which needs to be migrated to Gazebo 5. I don't know if there's a high overhead for this task or not. Hopefully not.

+1, can we also fix the velocity controller's feed-forward term?
ros-controls/ros_controllers#142

I commented directly in #142. It could make it as well.

@scpeters

This comment has been minimized.

Show comment
Hide comment
@scpeters

scpeters Nov 13, 2015

Regarding gazebo_ros_control and gazebo5, there's two concerns:

  • gazebo5 uses c++11, so anything downstream that builds plugins needs to use the GAZEBO_CXX_FLAGS, but that should already be fixed ( ros-simulation/gazebo_ros_pkgs@4d46186 )
  • We changed the behavior of Joint::SetVelocity and Joint::SetMaxForce, so anything using velocity commands (instead of torque commands) will need to use Joint::SetParam("vel") and Joint::SetParam("max_force"). I'm not sure if gazebo_ros_control uses a velocity control interface.

scpeters commented Nov 13, 2015

Regarding gazebo_ros_control and gazebo5, there's two concerns:

  • gazebo5 uses c++11, so anything downstream that builds plugins needs to use the GAZEBO_CXX_FLAGS, but that should already be fixed ( ros-simulation/gazebo_ros_pkgs@4d46186 )
  • We changed the behavior of Joint::SetVelocity and Joint::SetMaxForce, so anything using velocity commands (instead of torque commands) will need to use Joint::SetParam("vel") and Joint::SetParam("max_force"). I'm not sure if gazebo_ros_control uses a velocity control interface.
@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Nov 18, 2015

Member

Thanks @scpeters. The second point has not yet been addressed, and gazebo_ros_control does use a velocity control interface.

Member

adolfo-rt commented Nov 18, 2015

Thanks @scpeters. The second point has not yet been addressed, and gazebo_ros_control does use a velocity control interface.

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Nov 20, 2015

Member

FYI,
ros/rosdistro#9849
ros/rosdistro#9850

Pending feature requests can be merged as patch releases on top of 0.10

Member

adolfo-rt commented Nov 20, 2015

FYI,
ros/rosdistro#9849
ros/rosdistro#9850

Pending feature requests can be merged as patch releases on top of 0.10

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Nov 21, 2015

Member

I'll push some release notes to the robot control SIG in the coming days.

Member

adolfo-rt commented Nov 21, 2015

I'll push some release notes to the robot control SIG in the coming days.

@davetcoleman

This comment has been minimized.

Show comment
Hide comment
@davetcoleman
Member

davetcoleman commented Nov 22, 2015

Thanks @adolfo-rt !

@ipa-mdl

This comment has been minimized.

Show comment
Hide comment
@ipa-mdl

ipa-mdl Dec 1, 2015

Contributor

Now that the jade release is on its way, what about a new indigo release?

Contributor

ipa-mdl commented Dec 1, 2015

Now that the jade release is on its way, what about a new indigo release?

@bmagyar

This comment has been minimized.

Show comment
Hide comment
@bmagyar

bmagyar Dec 2, 2015

Member

+1
The diff_drive_controller could definitely use one!

I'm willing to do the release procedure once all lights are green.

Member

bmagyar commented Dec 2, 2015

+1
The diff_drive_controller could definitely use one!

I'm willing to do the release procedure once all lights are green.

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Dec 4, 2015

Member

Yes, on the agenda. I'm currently getting a failed test in diff_drive_controller. Can't release ros_controllers like that:

[diff_drive_controller.rosunit-diff_drive_limits_test/testAngularJerkLimits][FAILURE]
/home/adolfo/ros_control_ws/src/ros_controllers/diff_drive_controller/test/diff_drive_limits_test.cpp:150
The difference between new_odom.twist.twist.angular.z and 0.7 is 0.060075881205914228, which exceeds JERK_ANGULAR_VELOCITY_TOLERANCE, where
new_odom.twist.twist.angular.z evaluates to 0.76007588120591418,
0.7 evaluates to 0.69999999999999996, and
JERK_ANGULAR_VELOCITY_TOLERANCE evaluates to 0.050000000000000003.

I don't have time right now to dig into this. So if someone can reproduce that would accelerate the release.

Member

adolfo-rt commented Dec 4, 2015

Yes, on the agenda. I'm currently getting a failed test in diff_drive_controller. Can't release ros_controllers like that:

[diff_drive_controller.rosunit-diff_drive_limits_test/testAngularJerkLimits][FAILURE]
/home/adolfo/ros_control_ws/src/ros_controllers/diff_drive_controller/test/diff_drive_limits_test.cpp:150
The difference between new_odom.twist.twist.angular.z and 0.7 is 0.060075881205914228, which exceeds JERK_ANGULAR_VELOCITY_TOLERANCE, where
new_odom.twist.twist.angular.z evaluates to 0.76007588120591418,
0.7 evaluates to 0.69999999999999996, and
JERK_ANGULAR_VELOCITY_TOLERANCE evaluates to 0.050000000000000003.

I don't have time right now to dig into this. So if someone can reproduce that would accelerate the release.

@scpeters

This comment has been minimized.

Show comment
Hide comment
@scpeters

scpeters Dec 4, 2015

I'll try to take a look. It may be related to the first point I made above.

scpeters commented Dec 4, 2015

I'll try to take a look. It may be related to the first point I made above.

@efernandez

This comment has been minimized.

Show comment
Hide comment
@efernandez

efernandez Dec 6, 2015

Contributor

That test from the diff_drive_controller is probably not robust enough to time differences when it computes the relative odometry: it works for me (I can't reproduce it) and it works on Travis.

Anyway, I'm going to look into it to make it more robust to time differences. If that's not the reason, I'll increase the tolerance on the test for now, as this feature (jerk limits) shouldn't be blocking a release.

Contributor

efernandez commented Dec 6, 2015

That test from the diff_drive_controller is probably not robust enough to time differences when it computes the relative odometry: it works for me (I can't reproduce it) and it works on Travis.

Anyway, I'm going to look into it to make it more robust to time differences. If that's not the reason, I'll increase the tolerance on the test for now, as this feature (jerk limits) shouldn't be blocking a release.

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Feb 12, 2016

Member

Indigo:

ros/rosdistro#10491
ros/rosdistro#10492

I still see that diff drive test flakiness in my box, but pulled the trigger anyway.

Member

adolfo-rt commented Feb 12, 2016

Indigo:

ros/rosdistro#10491
ros/rosdistro#10492

I still see that diff drive test flakiness in my box, but pulled the trigger anyway.

@efernandez

This comment has been minimized.

Show comment
Hide comment
@efernandez

efernandez Feb 12, 2016

Contributor

@adolfo-rt I have some WIP branch for them, but I can relax that test that sometimes fails meanwhile.

In my branch (I repeat still WIP) I have an exhaustive set of unit tests that all pass, but curiously, that rostest doesn't, so I think it's related with some timing issue between runs.

Contributor

efernandez commented Feb 12, 2016

@adolfo-rt I have some WIP branch for them, but I can relax that test that sometimes fails meanwhile.

In my branch (I repeat still WIP) I have an exhaustive set of unit tests that all pass, but curiously, that rostest doesn't, so I think it's related with some timing issue between runs.

@adolfo-rt

This comment has been minimized.

Show comment
Hide comment
@adolfo-rt

adolfo-rt Feb 15, 2016

Member

@efernandez Let's bring in those changes in the next patch release. This one is already out.
ros/rosdistro#10497
ros/rosdistro#10498

Member

adolfo-rt commented Feb 15, 2016

@efernandez Let's bring in those changes in the next patch release. This one is already out.
ros/rosdistro#10497
ros/rosdistro#10498

@adolfo-rt adolfo-rt closed this Feb 15, 2016

@sytelus

This comment has been minimized.

Show comment
Hide comment
@sytelus

sytelus Jul 23, 2016

Looks like this issue is closed but there is still no ros-jade-gazebo-ros-control package :(.

sudo apt-get install ros-jade-gazebo-ros-control
E: Unable to locate package ros-jade-gazebo-ros-control

Any idea how to get ros-control package on Jade? This seems to be the only thing stopping to make gazebo demo work on Jade.

sytelus commented Jul 23, 2016

Looks like this issue is closed but there is still no ros-jade-gazebo-ros-control package :(.

sudo apt-get install ros-jade-gazebo-ros-control
E: Unable to locate package ros-jade-gazebo-ros-control

Any idea how to get ros-control package on Jade? This seems to be the only thing stopping to make gazebo demo work on Jade.

@bmagyar

This comment has been minimized.

Show comment
Hide comment
@bmagyar

bmagyar Jul 25, 2016

Member

Are you sure everything is ok with your installation?
https://github.com/ros/rosdistro/blob/master/jade/distribution.yaml#L1104
I checked packages.ros.org but couldn't find it there... it's weird.
Could you bring up this question here please? http://discourse.ros.org/c/release
I don't have an installation to test this on at the moment.

Member

bmagyar commented Jul 25, 2016

Are you sure everything is ok with your installation?
https://github.com/ros/rosdistro/blob/master/jade/distribution.yaml#L1104
I checked packages.ros.org but couldn't find it there... it's weird.
Could you bring up this question here please? http://discourse.ros.org/c/release
I don't have an installation to test this on at the moment.

@wjwwood

This comment has been minimized.

Show comment
Hide comment
@wjwwood

wjwwood Jul 25, 2016

Member

Jade hasn't been synced with Public since gazebo_ros_pkgs was released with gazebo_ros_control included: http://repositories.ros.org/status_page/ros_jade_default.html?q=gazebo_ros_control

Member

wjwwood commented Jul 25, 2016

Jade hasn't been synced with Public since gazebo_ros_pkgs was released with gazebo_ros_control included: http://repositories.ros.org/status_page/ros_jade_default.html?q=gazebo_ros_control

@bjornite

This comment has been minimized.

Show comment
Hide comment
@bjornite

bjornite Jul 25, 2016

Does that mean this issue will go away soon?

bjornite commented Jul 25, 2016

Does that mean this issue will go away soon?

@wjwwood

This comment has been minimized.

Show comment
Hide comment
@wjwwood

wjwwood Jul 25, 2016

Member

It means that the package will be available next time we sync Jade to the public repositories. I don't know when that will be, but probably within the next month.

You could use the shadow fixed repository and get the package now if you wanted: http://wiki.ros.org/ShadowRepository

Member

wjwwood commented Jul 25, 2016

It means that the package will be available next time we sync Jade to the public repositories. I don't know when that will be, but probably within the next month.

You could use the shadow fixed repository and get the package now if you wanted: http://wiki.ros.org/ShadowRepository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment