Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checking code and improvements to launch files #90

Merged
merged 5 commits into from Feb 7, 2017

Conversation

@prarobo
Copy link
Contributor

prarobo commented Jan 16, 2017

  • Some of the gstreamer elements sometimes don't get created properly. I have added small snippets to check if these elements are properly created.

  • Improvements to launch files


This change is Reviewable

@@ -88,19 +88,27 @@ namespace audio_transport
}

_convert = gst_element_factory_make("audioconvert", "convert");
if (!_encode) {

This comment has been minimized.

Copy link
@trainman419

trainman419 Jan 17, 2017

Contributor

Should this be if (!_convert) ?

This comment has been minimized.

Copy link
@prarobo

prarobo Jan 26, 2017

Author Contributor

You are right. Its fixed.

@trainman419 trainman419 merged commit c8eee40 into ros-drivers:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.