Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #109 #240

Merged
merged 3 commits into from Oct 11, 2016
Merged

Fix #109 #240

merged 3 commits into from Oct 11, 2016

Conversation

@IvanFeofanov
Copy link
Contributor

IvanFeofanov commented Aug 11, 2016

Replaced the function memcpy on a universal (little-endian/big-endian) functions varToArr and arrToVar

IvanFeofanov added 2 commits Aug 9, 2016
Added functions for the universal (little-endian/big-endian) memory copying
Replaced the function memcpy on a universal (little-endian/big-endian) functions varToArr, arrToVar
@mikepurvis

This comment has been minimized.

Copy link
Member

mikepurvis commented Aug 11, 2016

Thanks very much for looking at this! A few quick questions:

  • Which platform(s) are you testing on?
  • What is the intended meaning of the varToArr name? I find it kind of opaque; would you consider something like toLittleEndian/fromLittleEndian? Alternatively, http://stackoverflow.com/a/10346064/109517
@IvanFeofanov

This comment has been minimized.

Copy link
Contributor Author

IvanFeofanov commented Aug 11, 2016

  1. Platforms:
    • Atmega328
    • TP-Link TL-MR3020 (big-endian)
    • Linux x86-64 (little-endian)
  2. varToArr means copying data from variable to array. This functions work with both big-endian and little-endian.
@mikepurvis mikepurvis closed this Oct 11, 2016
@mikepurvis mikepurvis reopened this Oct 11, 2016
@mikepurvis

This comment has been minimized.

Copy link
Member

mikepurvis commented Oct 11, 2016

Just closed and reopened to get a travis test. Looks like there's an issue with size_t not being available?

@mikepurvis

This comment has been minimized.

Copy link
Member

mikepurvis commented Oct 11, 2016

Great, thanks!

@mikepurvis mikepurvis merged commit f8f3e76 into ros-drivers:jade-devel Oct 11, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.