Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try read all #248

Merged
merged 2 commits into from Sep 9, 2016
Merged

Try read all #248

merged 2 commits into from Sep 9, 2016

Conversation

@davidshin172
Copy link
Contributor

davidshin172 commented Sep 9, 2016

Fixes issue #247.
Two commits: One is the initial hotfix that tries to read requested amount of data no matter what, and the second one introduces a timeout behaviour.
Both are tested on my ROS software to work, but I currently have no mean to test and validate the timeout behaviour.

@mikepurvis

This comment has been minimized.

Copy link
Member

mikepurvis commented Sep 9, 2016

Logic seems reasonable to me. My development attention is primarily focused on rosserial_server, so if this works for you, I'm happy to merge.

@mikepurvis mikepurvis merged commit 196f5dd into ros-drivers:jade-devel Sep 9, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mikepurvis added a commit that referenced this pull request Mar 22, 2018
* tryRead: Try to read all bytes in a loop

* tryRead: Introduce back the short read error behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.