Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for python3 compatibility #500

Conversation

theseankelly
Copy link

Came up with these changes while hacking through enabling ROS Noetic on my Turtlebot.

  • use python3 import syntax in init
  • Use io.BytesIO instead of StringIO
  • Queue package renamed queue in python3
  • Work with byte arrays instead of unicode strings

* use python3 import syntax in init
* Use io.BytesIO instead of StringIO
* Queue package renamed queue in python3
* Work with byte arrays instead of unicode strings
@theseankelly theseankelly mentioned this pull request May 28, 2020
@theseankelly
Copy link
Author

It's come to my attention that these changes already are part of #480 -- it looks like I've missed a couple things, and #480 has already gone through code review. So, I am closing this PR

@theseankelly theseankelly deleted the noetic-python3-turtlebot branch June 11, 2020 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant