Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM_WORKSPACE syntax #147

Closed
mathias-luedtke opened this issue Mar 18, 2017 · 2 comments
Closed

UPSTREAM_WORKSPACE syntax #147

mathias-luedtke opened this issue Mar 18, 2017 · 2 comments

Comments

@mathias-luedtke
Copy link
Member

mathias-luedtke commented Mar 18, 2017

The current syntax of UPSTREAM_WORKSPACE along with ROSINSTALL_FILENAME is confusing.
I'd like to switch to an extended moveit_ci syntax:

UPSTREAM_WORKSPACE cases:

  • debian (default): as is
  • file:
    • ROSINSTALL_FILENAME is set, try
      1. $ROSINSTALL_FILENAME.$ROS_DISTRO
      2. $ROSINSTALL_FILENAME
    • otherwise try
      1. .travis.rosinstall.$ROS_DISTRO
      2. .travis.rosinstall
      3. .ci.rosinstall.$ROS_DISTRO
      4. .ci.rosinstall
      5. .rosinstall.$ROS_DISTRO
      6. .rosinstall
  • http*: as is
  • otherwise, try
    1. $UPSTREAM_WORKSPACE.$ROS_DISTRO
    2. $UPSTREAM_WORKSPACE.
    3. fail

This effectively combines both variables.
In addition the new file paths can reuse existiing files and don't need a travis prefix

Open issues:

  • Do we want to support multiple workspaces?
@ahoarau
Copy link

ahoarau commented Mar 22, 2017

Multiple workspaces would be really great !

@mathias-luedtke
Copy link
Member Author

A new systax was implemented in #361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants