Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated all package xml files to version 2 #232

Conversation

@dejaniraai
Copy link

dejaniraai commented Jul 2, 2019

Updated all the package.xml files to be of version 2

@gavanderhoorn

This comment has been minimized.

Copy link
Member

gavanderhoorn commented Jul 2, 2019

@dejaniraai: looks like github doesn't know about the email address you used to commit your changes.

Would you want to fix that?

@dejaniraai

This comment has been minimized.

Copy link
Author

dejaniraai commented Jul 2, 2019

@gavanderhoorn I am not sure how to fix the email issue. I do get all the notifications to the Github registered email.

@gavanderhoorn

This comment has been minimized.

Copy link
Member

gavanderhoorn commented Jul 2, 2019

It's fine. As long as the email used to commit is a correct one.

You can check that here at the top (in the From line).

industrial_msgs/package.xml Show resolved Hide resolved
@JeremyZoss JeremyZoss self-assigned this Jul 2, 2019
Copy link
Member

JeremyZoss left a comment

Changes look good. Builds with no problem. Thanks for the contribution!

@ros-industrial ros-industrial deleted a comment from trentwall Jul 2, 2019
@JeremyZoss JeremyZoss moved this from under review to completed in World ROS-Industrial Day 2019 - Issue board Jul 2, 2019
@JeremyZoss JeremyZoss moved this from completed to under review in World ROS-Industrial Day 2019 - Issue board Jul 2, 2019
@JeremyZoss JeremyZoss merged commit 762628c into ros-industrial:kinetic-devel Jul 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
World ROS-Industrial Day 2019 - Issue board automation moved this from under review to completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.