New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error industrial_collision_detection #70

Closed
Souphis opened this Issue Jun 19, 2018 · 14 comments

Comments

Projects
None yet
6 participants
@Souphis
Copy link

Souphis commented Jun 19, 2018

Hello, all. I want to use STOMP with my UR5 but I cannot compile industrial_collision_detection. I've tried compiling it on many machines (virtual os etc.) and always received following error:
error: redefinition of ‘struct collision_detection::DistanceRequest’ struct DistanceRequest
and of course many more.

I thought that maybe it was problem with Boost 1.66, however even on clean Ubuntu 16.04 with Boost 1.58 it doesn't work. I would be grateful for any advises.

My setup:

  • Ubuntu 16.04
  • ROS Kinetic
  • Packages for UR5 and Robotiq gripper (and many more ofc).
@ipa-mjp

This comment has been minimized.

Copy link

ipa-mjp commented Jun 19, 2018

Hello,
I am getting same problem. Did you solved your error?

@Souphis

This comment has been minimized.

Copy link

Souphis commented Jun 19, 2018

Not yet. However I've tried compile it on ROS-I Industrial Training VM and to my surprise, everything works well there. Maybe some dependencies are missing or sth.

@ipa-mjp

This comment has been minimized.

Copy link

ipa-mjp commented Jun 19, 2018

Hello,
Thank you so much. After installing all required dependency I am getting below of errors along with same error you mentioned.
stomp_error

@Souphis

This comment has been minimized.

Copy link

Souphis commented Jun 19, 2018

I got same errors on my PC. I compared ros packages installed on ROS-I VM and my Ubuntu, and there is not difference besides some additionals.

@ipa-mjp

This comment has been minimized.

Copy link

ipa-mjp commented Jun 19, 2018

Hello,
I don't have any idea what am doing wrong. Do you have any idea to resolve this error?
Thank you

@trent-weiss

This comment has been minimized.

Copy link

trent-weiss commented Jun 19, 2018

I am getting an identical error.

It appears the issue is related to redeclaring a struct collision_detection::DistanceRequest that already exists in MoveIt.

Not sure how to fix it.

@raghavendersahdev

This comment has been minimized.

Copy link

raghavendersahdev commented Jun 19, 2018

Hi @trent-weiss @ipa-mjp @Souphis . I had the exact same issue but I was able to build and run STOMP successfully after doing the following. I had to remove 3 packages. You need to remove the following folders / packages from industrial_move_it:

  • industrial_collision_detection: Recently everything that was in industrial_collision_detection package was merged into moveit (reason for multiple definitions) adding the ability to get detailed distance information. You will need to remove this package from the repository and try and build again. It may specifically check for the collision detection library name "IndustrialFCL" somewhere in the code which can now be removed because moveit supports the necessary capability. credits to @Levi-Armstrong for pointing me to this duplication. Also remove industrial_collision_detection, constraint_ik, industrial_moveit_benchmarking packages from any CMakeLists.txt where it explicityly finds these packages.
  • constraint_ik: package / folder as it had includes from the industrial_collision_detection package like this, this, this, etc
  • industrial_moveit_benchmarking: since this package has dependencies on the header files/classes obtained from the constraint_ik package, I removed this too.

After doing the above steps, a catkin build or catkin_make should be able to fix and compile it.

@ipa-mjp

This comment has been minimized.

Copy link

ipa-mjp commented Jun 21, 2018

Hello @raghavendersahdev ,

Thank you for your information. I try to follow step as you mention. But I have other errors that's obvious. The reason is

screenshot from 2018-06-21 10-10-25

  • If you already did this and compile and/or build fine. Than can you give me info/access of your repo? So that I can try in my pc. Did you create PR after solving this error?

  • If any one solve this problem please suggest me.
    Thank you.

@raghavendersahdev

This comment has been minimized.

Copy link

raghavendersahdev commented Jun 21, 2018

Hi @ipa-mjp as per my previous comment, you need to remove 3 all packages not just the industrial_collision_detection package. The 3 packages/folder you need to remove are:

  • industrial_collision_detection
  • constraint_ik
  • industrial_moveit_benchmarking

After removing these 3 packages completely, your code should successfully build....If there is a dependency of any of these packages listed in any CMakeLists.txt file, please remove that too.
Hope this helps.

@ipa-mjp

This comment has been minimized.

Copy link

ipa-mjp commented Jun 22, 2018

Hello @raghavendersahdev ,

Thank you so much for your help. Now after removing all 3 packages, I am able to compile and build.

@jrgnicho

This comment has been minimized.

Copy link
Member

jrgnicho commented Jul 5, 2018

@ipa-mjp by removing you mean deleting from the package.xml list or deleting the actual packages themselves?

@raghavendersahdev

This comment has been minimized.

Copy link

raghavendersahdev commented Jul 5, 2018

Hi @jrgnicho , both worked for me:

  • completely removing / deleteing the 3 packages also works, or Alternatively
  • simply removing from package.xml and using CATKIN_IGNORE for the three packages also worked

I removed / deleted industrial moveit and did catkin_ignore for the 2 packages (constriaint_ik and industrial_moveit_benchmarking). I did this as in my commit

@ipa-mjp

This comment has been minimized.

Copy link

ipa-mjp commented Jul 6, 2018

Hi @jrgnicho,

Even both worked for me.

@Ridhwanluthra

This comment has been minimized.

Copy link

Ridhwanluthra commented Jul 11, 2018

@raghavendersahdev if those packages are removed it will not be able to use those functionalities.
@ipa-hsd mentioned that this commit in moveit leads to the error.
Is it that the functionality from here was shifted to moveit? coz they seem similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment