Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roslaunch tests #362

Merged
merged 6 commits into from Jul 29, 2018

Conversation

ipa-nhg
Copy link
Member

@ipa-nhg ipa-nhg commented Jul 11, 2018

No description provided.

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is OK if you could address the minor comment I added.

And something for the future: could you please commit changes that address the issue and cleanup changes (such as the cleanup of CMakeLists.txt of ur_bringup and others) separately? That makes it easier to review things.

install(DIRECTORY launch DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION})
install(DIRECTORY config DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION})
install(DIRECTORY tests DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are typically not installed.

We don't install tests in any of our packages, so let's not start with these.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for all other packages.

@gavanderhoorn
Copy link
Member

Made the changes myself. Waiting for travis before merging.

@gavanderhoorn gavanderhoorn merged commit 2af9088 into ros-industrial:kinetic-devel Jul 29, 2018
@gavanderhoorn
Copy link
Member

Thanks @ipa-nhg for fixing this. 👍 🍻

@ipa-nhg ipa-nhg deleted the roslaunch_test branch August 2, 2018 07:44
AustinDeric pushed a commit to AustinDeric/universal_robot that referenced this pull request Nov 11, 2018
Squashed commits:

* add roslaunch tests
* add missed dependencies
* Do not install roslaunch tests.
dhled pushed a commit to dhled/universal_robot that referenced this pull request Dec 17, 2018
Squashed commits:

* add roslaunch tests
* add missed dependencies
* Do not install roslaunch tests.
ipa-nhg added a commit to ipa-nhg/universal_robot that referenced this pull request Jul 2, 2019
Squashed commits:

* add roslaunch tests
* add missed dependencies
* Do not install roslaunch tests.
ipa-nhg added a commit to ipa-nhg/universal_robot that referenced this pull request Jul 2, 2019
Squashed commits:

* add roslaunch tests
* add missed dependencies
* Do not install roslaunch tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants