New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add roslaunch tests #362
Add roslaunch tests #362
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is OK if you could address the minor comment I added.
And something for the future: could you please commit changes that address the issue and cleanup changes (such as the cleanup of CMakeLists.txt
of ur_bringup
and others) separately? That makes it easier to review things.
ur10_moveit_config/CMakeLists.txt
Outdated
install(DIRECTORY launch DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}) | ||
install(DIRECTORY config DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}) | ||
install(DIRECTORY tests DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are typically not installed.
We don't install tests in any of our packages, so let's not start with these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for all other packages.
Made the changes myself. Waiting for travis before merging. |
Thanks @ipa-nhg for fixing this. 👍 🍻 |
Squashed commits: * add roslaunch tests * add missed dependencies * Do not install roslaunch tests.
Squashed commits: * add roslaunch tests * add missed dependencies * Do not install roslaunch tests.
Squashed commits: * add roslaunch tests * add missed dependencies * Do not install roslaunch tests.
Squashed commits: * add roslaunch tests * add missed dependencies * Do not install roslaunch tests.
No description provided.