Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

when verifying package.xml assert there are no unknown tags #4

Closed
tfoote opened this Issue October 06, 2012 · 5 comments

2 participants

Tully Foote Dirk Thomas
Tully Foote
Owner

We had an incident with build_depends and run_depends tags were set and it was not obvious why the package had no dependencies.

The only unstructured area is in the export tag.

Dirk Thomas
Owner

The warnings can be changed into exceptions in the near future - so keeping this issue open until then.

Tully Foote
Owner

@dirk-thomas It's been 5 months do you know of anything this will break?

Tully Foote
Owner

diagnostic-analysis is just a warning about redundant dependencies, we should leave that at warning level. Which means that we're ready to close this out.

Dirk Thomas
Owner

We should not keep these warning messages but make them fatal exception. Simple rational: if any package has such a warning it will be printed in various use cases for every user using that package (every time the package xml is parsed i.e. rqt_dep).

Dirk Thomas dirk-thomas closed this in a29bad2 March 01, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.