Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REP-2000: Update the dependency versions for OpenEmbedded and webOS OSE platforms #234

Open
wants to merge 2 commits into
base: master
from

Conversation

@shr-project
Copy link

shr-project commented Feb 11, 2020

No description provided.

@shr-project shr-project requested a review from herb-kuta-lge Feb 11, 2020
@shr-project shr-project force-pushed the shr-project:webos branch from 875576e to 520fd0a Feb 11, 2020
Copy link
Contributor

herb-kuta-lge left a comment

Commit message changes

  • Summary: REP-2000: Update for versions provided by meta-ros Milestone 11
  • Why mention a version of webOS OSE that isn't (yet) supported by meta-ros?
  • OpenEmbedded releases OpenEmbedded release series`
  • Dunfell), list -> Dunfell), so list
  • (last finished release) -> (the last stable release series)
  • lists versions in other releases -> lists the versions provided by the other release series
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Show resolved Hide resolved
rep-2000.rst Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
rep-2000.rst Outdated Show resolved Hide resolved
@herb-kuta-lge

This comment has been minimized.

Copy link
Contributor

herb-kuta-lge commented Feb 13, 2020

REP-2000: Update the dependency versions for OpenEmbedded and webOS OSE platforms -> REP-2000: Update the dependency versions for Milestone 11 of meta-ros

@shr-project shr-project force-pushed the shr-project:webos branch 2 times, most recently from 96de77f to 7d2b4bb Feb 14, 2020
@shr-project

This comment has been minimized.

Copy link
Author

shr-project commented Mar 11, 2020

@mjcarroll @nuclearsandwich Hi, is something blocking the merge of this? We were planing to submit the same for foxy after this PR is merged in master.

@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Mar 11, 2020

Please see my comment / concern on the Foxy PR: #217 (comment)

@herb-kuta-lge

This comment has been minimized.

Copy link
Contributor

herb-kuta-lge commented Mar 16, 2020

@dirk-thomas < Every (non-EOL) ROS distro will always supported under at least one stable OpenEmbedded release series; it's just which one will change throughout the lifetime of the ROS distro. This is why we have dropped "Thud" from the OpenEmbedded column titles and added "**" to indicate that it's a "rolling distribution". Would it be clearer if we spelled this out in the explanation of the "**" indication?

@shr-project shr-project force-pushed the shr-project:webos branch 3 times, most recently from 0e4eee1 to 4af3961 Mar 18, 2020
Copy link
Member

dirk-thomas left a comment

Would it be clearer if we spelled this out in the explanation of the "**" indication?

Yes, that would be good since it diverges from all other currently targeted platforms.

@@ -407,7 +406,7 @@ Dependency Requirements:

" * " means that this is not the upstream version (available on the official Operating System repositories) but a package distributed by OSRF or the community (package built and distributed on custom repositories).

" ** " Rolling distributions will see multiple version changes of these dependencies during their lifetime.
" ** " Rolling distributions will see multiple version changes of these dependencies during their lifetime. The versions shown for OpenEmbedded are those provided by the 3.1 Dunfell release series; the versions provided by the other supported release series are listed here: https://github.com/ros/meta-ros/wiki/Package-Version-Differences .

This comment has been minimized.

Copy link
@dirk-thomas

dirk-thomas Mar 19, 2020

Member

Nitpick: new sentence should start on new line (see style guide).

Same below.

@shr-project shr-project force-pushed the shr-project:webos branch from 4af3961 to 5393394 Mar 19, 2020
@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Mar 19, 2020

@mjcarroll @nuclearsandwich Please review and merge.

Martin Jansa added 2 commits Dec 17, 2019
* meta-ros now supports multiple OpenEmbedded release series (2.6 Thud,
  2.7 Warrior, 3.0 Zeus and 3.1 Dunfell), so list the dependency
  versions provided by 3.1 Dunfell (soon to be released LTS release)
  and include a link to the meta-ros wiki page that lists the versions
  provided by the other release series.

* Mark OpenEmbedded/webOS OSE as rolling distributions because the
  versions of the dependencies they provide change during the lifetime
  of their releases (e.g. openssl and Qt were upgraded in webOS OSE for
  2.6 Thud).

* Starting with 2.7 Warrior, ROS 2 with OpenEmbedded is built for
  raspberrypi4-64 => add arm64 as a targeted platform for it.

Signed-off-by: Martin Jansa <martin.jansa@lge.com>
* it was specified in Dashing, but missing completely in Eloquent

Signed-off-by: Martin Jansa <martin.jansa@lge.com>
@shr-project shr-project force-pushed the shr-project:webos branch from 5393394 to a9d56be Mar 20, 2020
@ros-discourse

This comment has been minimized.

Copy link

ros-discourse commented Mar 20, 2020

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-03-18/13313/1

Copy link
Contributor

mjcarroll left a comment

LGTM. @nuclearsandwich it can be merged with your approval.

@dirk-thomas

This comment has been minimized.

Copy link
Member

dirk-thomas commented Mar 30, 2020

@nuclearsandwich Friendly ping.

jacobperron added a commit that referenced this pull request Mar 31, 2020
Copied changes applied to Dashing and Eloquent in #234.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.