Jump to conversation
Unresolved conversations (7)
@mateus-amarante mateus-amarante Oct 9, 2020
```suggestion _global_options = None ``` This is not needed
src/rosdep2/main.py
@mateus-amarante mateus-amarante Oct 9, 2020
I think it is better to keep this ```suggestion def _get_default_RosdepLookup(options): ```
src/rosdep2/main.py
@mateus-amarante mateus-amarante Oct 9, 2020
This is no longer needed ```suggestion ```
src/rosdep2/main.py
@mateus-amarante mateus-amarante Oct 9, 2020
```suggestion Allowed: "build", "buildtool", "build_export", "run", "test", "exec", "doc" ``` It also supports build_export, exec, and doc dependencies
src/rosdep2/lookup.py
mateus-amarante nuclearsandwich
@mateus-amarante mateus-amarante Oct 9, 2020
```suggestion ``` Not needed
src/rosdep2/main.py
@mateus-amarante mateus-amarante Oct 9, 2020
```suggestion ``` This is not needed
src/rosdep2/main.py
@mateus-amarante mateus-amarante Oct 9, 2020
```suggestion nosetests --with-coverage --cover-package=rosdep2 --with-xunit test ``` It was my bad. I accidentally committed it.
Makefile
mateus-amarante nuclearsandwich
Resolved conversations (0)