add default_config verb to create a default configuration file #45
Conversation
mikeferguson
left a comment
mikeferguson
left a comment
There was a problem hiding this comment.
I just tried this out (rebased on top of main) and I do think it would be a helpful addition to this tool (everything worked as advertised)
Yadunund
left a comment
Yadunund
left a comment
There was a problem hiding this comment.
@ottojo thanks for the contribution and thank you @mikeferguson for reviewing this PR.
Left a couple of nitpicks to address before we can merge.
Alternatively @mikeferguson if you could open a PR with the main rebase and the copyright headers added, happy to merge that in as long as the origin commit authored by @ottojo is preserved.
| @@ -0,0 +1,16 @@ | |||
|
|
|||
There was a problem hiding this comment.
I added a header, not sure if it is expected to dedicate copyright to OSRF, that can be done if desired.
| @@ -0,0 +1,31 @@ | |||
| import os | |||
ottojo
force-pushed
the
verb_default_config
branch
from
d4dd78f to
08c4fb3
Compare
|
Nice to see some activity here, I think package documentation is such an important aspect of ROS with much room for improvement! I rebased the commit to latest main, and tested it myself as well. |
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
Thanks for pushing this forward
|
Looks like our linters have flagged some formatting issues with the changes proposed. Do you mind addressing them? |
Signed-off-by: Jonas Otto <jonas@jonasotto.com>
ottojo
force-pushed
the
verb_default_config
branch
from
08c4fb3 to
62f8e6e
Compare
|
should be fixed! @Yadunund |
4 participants
Information about the config file format is hard to find, i think this makes it easier to use.
This adds a verb
default_configwhich just writes the default config file already present in the code to a file, to be customized by the package author.