Additional changes to support ament_python pkgs #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <sloretz@google.com>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
force-pushed
the
yadu/ament_python_support
branch
from
6de2f28 to
dd3c982
Compare
aprotyas
reviewed
Mar 22, 2023
Comment on lines
+30
to
+32
| def esc_backslash(path): | ||
| """Escape backslashes to support Windows paths in strings.""" | ||
| return path.replace('\\', '\\\\') if path else path |
There was a problem hiding this comment.
Couldn't instantiating pathlib.Path objects handle this?
There was a problem hiding this comment.
I like that idea but think that this is going into the config of the next stage where it is then needed to be escaped.
I'd suggest considering switching to this as an enhancement for the future.
There was a problem hiding this comment.
I've opened a ticket to follow up on this #50
tfoote
approved these changes
Mar 22, 2023
Comment on lines
+30
to
+32
| def esc_backslash(path): | ||
| """Escape backslashes to support Windows paths in strings.""" | ||
| return path.replace('\\', '\\\\') if path else path |
There was a problem hiding this comment.
I like that idea but think that this is going into the config of the next stage where it is then needed to be escaped.
I'd suggest considering switching to this as an enhancement for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #28
Should probably merge #47 in first.
It closes #48 by addressing all remaining issues (except the bonus item).